-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds google analytics to content security policy #1027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njbriggs
reviewed
May 23, 2023
seanfeld
force-pushed
the
podesta/content-header-analytics
branch
from
May 23, 2023 06:35
2adeeee
to
f79374d
Compare
sumengwang
approved these changes
May 23, 2023
dli357
requested changes
May 23, 2023
seanfeld
commented
May 23, 2023
server/express.js
Outdated
@@ -85,6 +86,7 @@ export const stripAuthHeadersInProxyMode = (cdapConfig, res) => { | |||
|
|||
function makeApp(authAddress, cdapConfig, uiSettings) { | |||
var app = express(); | |||
const serverNonce = crypto.randomBytes(16).toString('base64'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seanfeld
force-pushed
the
podesta/content-header-analytics
branch
from
May 23, 2023 22:40
73ebcbd
to
9a6cdfd
Compare
seanfeld
force-pushed
the
podesta/content-header-analytics
branch
from
May 23, 2023 22:44
9a6cdfd
to
019f2fa
Compare
dli357
reviewed
May 23, 2023
dli357
approved these changes
May 23, 2023
…ent-header-analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google analytics content security policy
Description
Adds Tag manager and analytics to the content security policy based on the guidance here https://developers.google.com/tag-platform/tag-manager/web/csp .
PR Type