CDAP-14562 fixed a classloading issue with output formats #10832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just using the output format's classloader as the context classloading when creating the RecordWriter, use a CombineClassLoader of the output format's classload and the current context classloader. This prevents issues where classes in the Hadoop classpath are not visible when creating the RecordWriter. More specifically, this fixes issues with XML parsers required by the S3 filesystem. If the program/plugin does not have xml dependencies packaged (they shouldn't need to), it should not result in ClassNotFound exceptions.
rohitsinha54
approved these changes
Nov 9, 2018
|
Build green. Merging. |
rohitsinha54
deleted the
bugfix_release/CDAP-14562-fix-classloading-output-issue
branch
This was referenced Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just using the output format's classloader as the
context classloading when creating the RecordWriter, use a
CombineClassLoader of the output format's classload and the current
context classloader. This prevents issues where classes in the
Hadoop classpath are not visible when creating the RecordWriter.
More specifically, this fixes issues with XML parsers required
by the S3 filesystem. If the program/plugin does not have xml
dependencies packaged (they shouldn't need to), it should not
result in ClassNotFound exceptions.