Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDAP-14562 fixed a classloading issue with output formats #10832

Merged
merged 1 commit into from Nov 9, 2018
Merged

CDAP-14562 fixed a classloading issue with output formats #10832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...src/main/java/co/cask/cdap/internal/app/runtime/batch/dataset/output/MultipleOutputs.java
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@
import co.cask.cdap.app.metrics.MapReduceMetrics;
import co.cask.cdap.common.conf.ConfigurationUtil;
import co.cask.cdap.common.lang.ClassLoaders;
import co.cask.cdap.common.lang.CombineClassLoader;
import co.cask.cdap.proto.id.EntityId;
import com.google.common.base.Preconditions;
import com.google.common.base.Splitter;
Expand Down Expand Up @@ -193,9 +194,16 @@ private synchronized RecordWriter getRecordWriter(String namedOutput) throws IOE
}

ClassLoader outputFormatClassLoader = outputFormatClass.getClassLoader();
// Use a CombineClassLoader of the output format's classloader and the context classloader
// This is to prevent class not found issues for classes that are visible to the system, but not to the
// program/plugin. More specifically, this happens for XML parsers that are in the Hadoop classpath but usually
// not packaged in programs and plugins.
// see CDAP-14562 for more info
ClassLoader outputClassLoader = new CombineClassLoader(outputFormatClassLoader,
Thread.currentThread().getContextClassLoader());
// This is needed in case the OutputFormat's classloader conflicts with the program classloader (for example,
// TableOutputFormat).
ClassLoader oldClassLoader = ClassLoaders.setContextClassLoader(outputFormatClassLoader);
ClassLoader oldClassLoader = ClassLoaders.setContextClassLoader(outputClassLoader);

try {
// We use ReflectionUtils to instantiate the OutputFormat, because it also calls setConf on the object, if it
Expand Down