[CDAP-17068] Display message when field level lineage is too large to… #12453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Message:
|
jennac3
reviewed
Jul 16, 2020
| @@ -250,10 +269,35 @@ class LineageSummary extends React.Component<{ classes }, ILineageState> { | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| if (error) { | |||
There was a problem hiding this comment.
we can do
if (error) return null;
return (
...
);
There was a problem hiding this comment.
no we cannot. If there is error we want to display this, otherwise, there's already an actual component being rendered
| // there is proper pagination for the FLL response from backend. This limit is approximately | ||
| // 1500 fields going into 1500 fields | ||
| function isFLLResponseTooLarge(response) { | ||
| const CHARACTER_LIMIT = 50000; |
There was a problem hiding this comment.
Should this be defined at the top of the file?
There was a problem hiding this comment.
the constant is not really applicable anywhere else
yukiej
reviewed
Jul 17, 2020
cdap-ui/app/cdap/components/FieldLevelLineage/v2/Context/FllContext.tsx
Outdated
Show resolved
Hide resolved
elfenheart
force-pushed
the
feature-ui/CDAP-17068-fll-bail-out
branch
from
1a7a9cd
to
10f56a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… display
Either the response is greater than 50K characters, or API takes longer than 20 seconds, we will display message that Field level lineage data is too large to display.
JIRA: https://issues.cask.co/browse/CDAP-17068
Build: https://builds.cask.co/browse/CDAP-UDUT725