This repository has been archived by the owner on May 22, 2023. It is now read-only.
Feature/plugin data store #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their plugins. Types of resources a plugin supports will be defined by the plugin. For example, the 'chef-solo' automator type will specify that it supports 'cookbook', 'databag', and 'role' resource types. A tenant admin will then be able to upload resources for cookbooks, databags, and roles with a given name and version for identification. Resource versions can then be activated, meaning that version of the resource will be pushed to provisioners when a special 'sync' call is made by the admin. Implementation includes a PluginResourceMetaStoreView that keeps track of what resources exist and which versions are active. There is then a PluginStore that provides input and output streams for writing to and reading from whatever backend is used to store the plugin resources. System admins can implement the PluginStore class to support different storage backends, with Loom including an in-memory backend for tests and a local file system backend, with the idea that we would add support for distributed systems that would work better for HA purposes.
to a map instead of a flat list so that versions for a resource are grouped together. Also changed active filter to be a parameter instead of a separate call with a separate signature.
of activating it, and each resource has a status which is inactive, staged, active, or unstaged.
instead of deleting from the table for historical purposes.
…a-store Conflicts: server/src/test/java/com/continuuity/loom/BaseTest.java
|
@albertshau has documentation been updated for this ? |
|
good reminder... I will update them |
| .. include:: /rest/rest-links.rst | ||
|
|
||
| Using the Loom admin REST API, you can upload and manage plugin resources. | ||
| Each tenant admin can upload resources that plugins can use, such as chef cookbooks |
There was a problem hiding this comment.
It would be better to define a plugin first, and then talk about plugin resources, etc.
…a-store Conflicts: CHANGELOG.md
| import com.google.common.base.Preconditions; | ||
|
|
||
| /** | ||
| * Metadata about a plugin resource, including a unique id, a name, a version, and status. |
There was a problem hiding this comment.
I don't see a unique id anywhere in the implementation.
There was a problem hiding this comment.
good catch, removed.
| "deleted BOOLEAN, " + | ||
| "create_time TIMESTAMP," + | ||
| "delete_time TIMESTAMP )", | ||
| dbConnectionPool); |
There was a problem hiding this comment.
This table probably should have a primary key since its counterpart in MySQL has it.
|
I'm done with my review, please address comments. |
…a-store Conflicts: CHANGELOG.md server/src/main/java/com/continuuity/loom/store/guice/StoreModule.java server/src/test/java/com/continuuity/loom/BaseTest.java
with refactoring store guice modules, renaming classes and variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store for uploading and managing plugin resources like cookbooks, scripts, etc.