This repository has been archived by the owner on May 22, 2023. It is now read-only.
Changing the queued element sent to the Solver to allow different #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types of solver tasks to allow solving for cluster creation or addition of services or any other type of cluster operation that requires solver interaction. As part of this, renaming ClusterRequest to ClusterCreateRequest.
…ent-types-of-solve-tasks Conflicts: server/src/main/java/com/continuuity/loom/codec/json/JsonSerde.java server/src/test/java/com/continuuity/loom/http/LoomClusterHandlerTest.java
| */ | ||
| public class SolverRequest { | ||
| private final Type type; | ||
| private final String serializedRequest; |
There was a problem hiding this comment.
Maybe call it jsonRequest for more clarity.
|
Minor comments, otherwise LGTM |
albertshau
added a commit
that referenced
this pull request
Apr 14, 2014
…f-solve-tasks Changing the queued element sent to the Solver to allow different
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types of solver tasks to allow solving for cluster creation or
addition of services or any other type of cluster operation that
requires solver interaction. As part of this, renaming
ClusterRequest to ClusterCreateRequest.