[CDAP-15787] Adding failure collector api for format plugins #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2019
CuriousVini
force-pushed
the
feature/add-validation-format
branch
2 times, most recently
from
35c86c7
to
401aad1
Compare
CuriousVini
force-pushed
the
feature/add-validation-format
branch
from
401aad1
to
acc0a7f
Compare
albertshau
reviewed
Sep 20, 2019
format-blob/src/main/java/io/cdap/plugin/format/blob/input/BlobInputFormatProvider.java
Outdated
Show resolved
Hide resolved
format-common/src/main/java/io/cdap/plugin/format/plugin/AbstractFileSink.java
Outdated
Show resolved
Hide resolved
format-common/src/main/java/io/cdap/plugin/format/plugin/AbstractFileSink.java
Outdated
Show resolved
Hide resolved
| new SimpleDateFormat(suffix); | ||
| } | ||
| if (!containsMacro("format")) { | ||
| if (!containsMacro(NAME_FORMAT)) { |
There was a problem hiding this comment.
this shouldn't have been here before, format is not macro enabled so this will always be true
There was a problem hiding this comment.
that's weird... it's not annotated as a macro above.
There was a problem hiding this comment.
I will remove macros for format property.
| Schema schema = config.getSchema(); | ||
| FileFormat fileFormat = config.getFormat(); | ||
| FileFormat fileFormat = getFileFormat(); | ||
| Schema schema = null; | ||
| if (fileFormat != null) { |
There was a problem hiding this comment.
this shouldn't have been here either, format is required.
There was a problem hiding this comment.
format is macro enabled tho
format-common/src/main/java/io/cdap/plugin/format/plugin/AbstractFileSource.java
Outdated
Show resolved
Hide resolved
albertshau
approved these changes
Sep 20, 2019
CuriousVini
force-pushed
the
feature/add-validation-format
branch
from
38b8abe
to
c4fce80
Compare
|
build is green: https://builds.cask.co/browse/HYP-BAD581-22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires changes from cdapio/cdap#11638 to be merged first
build: https://builds.cask.co/browse/HYP-BAD581-13