Make Gabbi SNI aware. (fixes #305) #306
Conversation
|
Thanks for providing this, great addition. I'm surprised this hasn't come up before, but I guess it is because most of the time gabbi is being used to test things where TLS is terminated prior to the app being tested. Normally I'd want a test of some kind to go along with this, but since there aren't already other test of httpclient, I'll deal with that myself, later. Look for a new release probably tomorrow. Out of curiosity: Are you using gabbi yourself? For anything interesting? It's always useful to know more about what people are doing with it. |
This is basically a hack to get it working in the way I needed it to. I thought I'd submit a PR hoping you'd see what I was doing and then do it better. If you think I've done an okay job as it is, then brilliant!
Awesome. No rush, as I say... it was just to get something working for my use case.
The reason I needed SNI working was because we're using Gabbi to test various changes to Akamai's Edge (behaviors, etc.). Gabbi fits our needs perfectly and we're hoping for some wider adoption once we have a slick testsuite. |
|
Whoops, that might have been premature. I had assumed the test actions had run automatically and passed, but looks like they didn't run for some reason. There are some issues, but I'll fix them. |
|
It's a bug in wsgi_intercept, which I'll fix |
|
2.5.0 is on pypi, and requires 1.9.3 of wsgi-intercept, which is on pypi too |
|
So it turns out this change identified a problem in how we are using urllib3.PoolManager, that is probably a bug in urllib3 But it means that 2.5.0 is breaking some CI situations out there in the real world, so I've yanked it on pypi to make it clear that it has a problem. 2.5.1 will come out when the urllib3 issue is resolved. See: #310 |
The recent change[1] in gabbi revealed an issue with urllib3 and now http requests no longer works. This causes failure in some components like heat-tempest-plugin[2]. This change pins version of gabbi to exclude that change until the issue is fixed in urllib3[3]. Note that gabbi 2.5.0 has been yanked because of this known issue. [1] cdent/gabbi#306 [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026724.html [3] urllib3/urllib3#2534 Change-Id: Iaaf5d1615d57ae9e53a0c64a0bcf0aba02144bf0
* Update requirements from branch 'master'
to 60103fbaba0ef217b9c87729dd03e84196e1a0c4
- Merge "Pin gabbi to <2.5.0"
- Pin gabbi to <2.5.0
The recent change[1] in gabbi revealed an issue with urllib3 and now
http requests no longer works. This causes failure in some components
like heat-tempest-plugin[2].
This change pins version of gabbi to exclude that change until
the issue is fixed in urllib3[3].
Note that gabbi 2.5.0 has been yanked because of this known issue.
[1] cdent/gabbi#306
[2] http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026724.html
[3] urllib3/urllib3#2534
Change-Id: Iaaf5d1615d57ae9e53a0c64a0bcf0aba02144bf0
The recent change[1] in gabbi breaks http requests, which results in failures in some components like heat-tempest-plugin[2]. This change pins version of gabbi to exclude that change until the issue is fixed in gabbi[3] or urllib3[4] which gabbi depends on. [1] cdent/gabbi#306 [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026724.html [3] cdent/gabbi#309 [4] urllib3/urllib3#2534 Change-Id: Iaaf5d1615d57ae9e53a0c64a0bcf0aba02144bf0
No description provided.