Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu #136

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Add a context menu #136

merged 2 commits into from
Nov 9, 2019

Conversation

jecaro
Copy link
Contributor

@jecaro jecaro commented Oct 27, 2019

This PR adds a very simple context menu to Termonad #12.

For now I've put only copy/paste items. But adding existing actions to the menu is pretty straight forward.

I've worked a bit on adding an action to open an url in a navigator. It's not as easy at it seems for two reasons:

@cdepillabout cdepillabout self-requested a review October 28, 2019 02:41
@cdepillabout
Copy link
Owner

cdepillabout commented Nov 1, 2019

@jecaro Sorry for not getting to this right away. I've been traveling and I may not have a time to really take a look at this for another week or so.

However, after taking a quick look at it, I think this is looking pretty good.

Also, thanks a lot for fixing stuff upstream. You may want to reply to haskell-gi/haskell-gi#109 just making sure that garetxe knows there is someone else blocked on this.

(Or you might be interested in actually fixing haskell-gi/haskell-gi#109 upstream as well? I'm sure garetxe would appreciate the help.)

@cdepillabout
Copy link
Owner

Also, @mimi1vx, it looks like you added a 👍, so if you wanted to review this, I'd appreciate the additional eyes on this!

@jecaro
Copy link
Contributor Author

jecaro commented Nov 2, 2019

You're right @cdepillabout , I just sent a comment on the issue.

Take your time reviewing this, there is no hurry, and enjoy your trip !

@cdepillabout
Copy link
Owner

This has been implemented in #136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants