Full Continuous Deployment CDEvents to render as CloudEvent and schema validation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents' into mergingtest # Conflicts: # pom.xml # src/main/java/dev/cdevents/constants/CDEventConstants.java # src/test/java/dev/cdevents/CDEventsTest.java
rjalander
reviewed
May 5, 2023
| * @param subjectType | ||
| * sets the subject type | ||
| */ | ||
| public void setSubjectType(CDEventConstants.SubjectType subjectType) { |
There was a problem hiding this comment.
Subject Type will be set to "service" for this event, method to set the type is not needed.
rjalander
reviewed
May 5, 2023
| * @param subjectType | ||
| * sets the subject type | ||
| */ | ||
| public void setSubjectType(CDEventConstants.SubjectType subjectType) { |
There was a problem hiding this comment.
same as above comment, can be removed.
rjalander
reviewed
May 5, 2023
| * @param subjectType | ||
| * sets the subject type | ||
| */ | ||
| public void setSubjectType(CDEventConstants.SubjectType subjectType) { |
There was a problem hiding this comment.
same as above comment, can be removed.
rjalander
reviewed
May 5, 2023
| * @param subjectType | ||
| * sets the subject type | ||
| */ | ||
| public void setSubjectType(CDEventConstants.SubjectType subjectType) { |
rjalander
reviewed
May 5, 2023
| * @param subjectType | ||
| * sets the subject type | ||
| */ | ||
| public void setSubjectType(CDEventConstants.SubjectType subjectType) { |
… some lint errors.
rjalander
approved these changes
May 5, 2023
afrittoli
approved these changes
May 5, 2023
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #44, to implement other Continuous Deployment events