Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small typos in Wiki / Types of Boxes #234

Closed
schorfma opened this issue Dec 2, 2022 · 3 comments
Closed

Two small typos in Wiki / Types of Boxes #234

schorfma opened this issue Dec 2, 2022 · 3 comments

Comments

@schorfma
Copy link

schorfma commented Dec 2, 2022

Hello,


I noticed two small typos on the Wiki page Types of Boxes:

Types of Boxes / Box Dots

Support for traversing box lists as well!

my_box = Box({'data': [ {'rabbit': 'hole'} ] }, box_dots=True)
print(data.data[0].rabbit)
# hole

To change

my_box = Box({'data': [ {'rabbit': 'hole'} ] }, box_dots=True)
- print(data.data[0].rabbit)
+ print(my_box.data[0].rabbit)
# hole

Types of Boxes / Box Recast Values

If it cannot be converted, it will raise a BoxValueError (catachable with either BoxError or ValueError as well)

To change

- If it cannot be converted, it will raise a `BoxValueError` (catachable with either `BoxError` or `ValueError` as well)
+ If it cannot be converted, it will raise a `BoxValueError` (catchable with either `BoxError` or `ValueError` as well)

Thank you for your work on the Box library and kind regards
Martin

@cdgriffith
Copy link
Owner

Updated, thank you for finding and reporting them!

@cdgriffith
Copy link
Owner

Actually going to keep this open just so when I do another release I remember to add you to contributors ;-)

@cdgriffith cdgriffith reopened this Dec 3, 2022
cdgriffith added a commit that referenced this issue Feb 4, 2023
* Adding #169 default functions with the box_instance and key parameter (thanks to Коптев Роман Викторович)
* Adding #170 Be able to initialize with a flattened dict - by using DDBox (thanks to Ash A.)
* Adding #192 box_dots treats all keys with periods in them as separate keys (thanks to Rexbard)
* Adding #211 support for properties and setters in subclasses (thanks to Serge Lu and David Aronchick)
* Adding #226 namespace to track changes to the box (thanks to Jacob Hayes)
* Adding #236 iPython detection to prevent adding attribute lookup words (thanks to Nishikant Parmar)
* Adding #238 allow ``|`` and ``+`` for frozen boxes (thanks to Peter B)
* Adding new DDBox class (Default Dots Box) that is a subclass of SBox
* Fixing #235 how ``|`` and ``+`` updates were performed for right operations (thanks to aviveh21)
* Fixing #234 typos (thanks to Martin Schorfmann)
* Fixing no implicit optionals with type hinting
@cdgriffith
Copy link
Owner

Added in 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants