Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sometimes it shows "conversion complete" when it errors #101

Closed
cdgriffith opened this issue Oct 26, 2020 · 1 comment
Closed

[BUG] Sometimes it shows "conversion complete" when it errors #101

cdgriffith opened this issue Oct 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@cdgriffith
Copy link
Owner

When FFmpeg does not return an error code, but still stops halfway through the encode FastFlix will still treat it as a success as there was no error code given by FFmpeg.

The behavior will have to change to also check log messages.
@cdgriffith cdgriffith added the bug Something isn't working label Oct 26, 2020
cdgriffith added a commit that referenced this issue Oct 26, 2020
@cdgriffith
* Adding HDR10+ support for x265
07a1bc1 
* Adding x265 params hdr10, hdr10-opt, aq-mode and repeat-headers
* Fixing #103 x265-params were being pre-pended with an extra ":"
* Fixing #101 FFmpeg status codes now taken into account for errors
@cdgriffith cdgriffith mentioned this issue Oct 26, 2020
Merged
cdgriffith added a commit that referenced this issue Oct 27, 2020
@cdgriffith
Version 3.4.0 (#105)
2772023 
* Adding #83 HDR10+ support for x265 (thanks to SlashX)
* Adding x265 params hdr10, hdr10-opt, aq-mode and repeat-headers
* Adding basic splash info and waiting cursor for events
* Adding button to open config file from setting panel
* Changing that autocrop will test two spots if possible (thanks to HannesJo0139)
* Changing covers generated in their own temp directory
* Fixing #103 x265-params were being pre-pended with an extra ":" (thanks to Zeid164)
* Fixing #101 FFmpeg status codes now taken into account for errors
@cdgriffith
Copy link
Owner Author

Issue should be fixed in 3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdgriffith