Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust queue that is recoverable #166

Closed
cdgriffith opened this issue Jan 9, 2021 · 12 comments
Closed

More robust queue that is recoverable #166

cdgriffith opened this issue Jan 9, 2021 · 12 comments
Labels
feature request New idea for project
Projects
FastFlix

Comments

@cdgriffith
Copy link
Owner

Reported from bmcassagne in #162
@cdgriffith cdgriffith added the feature request New idea for project label Jan 9, 2021
@E-t-z
Copy link

E-t-z commented Jan 10, 2021

I think, possibility to save/load queue would be helpful as well.

@bmcassagne
Copy link

Personally, I'm never going to save or load a queue. It should autosave at the beginning of every conversion and it should autorecover when you open the app.

@cdgriffith cdgriffith added this to Higher Priority in FastFlix Jan 11, 2021
This was referenced Jan 13, 2021
Closed
Closed
@E-t-z
Copy link

E-t-z commented Jan 15, 2021

Just had an power outage + UPS failure and lost my 10 video queue... 😢

@bmcassagne
Copy link

Hah. I had the same thing happen to 3 computers. The other issue is I have to manually search afterward to see which ones finished. Very inconvenient! Now I usually just have 2 or 3 items in the queue but mine usually take 2 days per video.

@E-t-z
Copy link

E-t-z commented Jan 16, 2021 •
edited

Well, I feel your pain.

Encoding with x265, preset slow, crf 16/17 takes approx 2,5-3 days per video...and when power suddenly disappears, you will start over...

I do have fairly powerful system, with liquid cooled 9900k, it can even reach blazing fast 0.8fps... 😃

It makes me wonder, is there a really huge quality difference between medium and slow, or should I try switch to NVENC instead... 🤔

@bmcassagne
Copy link

Oh wow. I have an i7-7820HK in my laptop and I'm getting 0.8 fps on slow but CRF 21-23. I can't see any difference below 21 CRF and the files get really big.

@E-t-z
Copy link

E-t-z commented Jan 17, 2021 •
edited

@bmcassagne after some minor tweaking (and leaving it alone), it does improve a bit ~2fps.
It would still take almost 1,8 days to complete single video...hence recoverable queue would still help a lot... 🙂

@bmcassagne
Copy link

That's some pretty good tweaking. What did you change?

@E-t-z
Copy link

E-t-z commented Jan 18, 2021 •
edited

  1. Stopped all other activities on that machine.
  2. Higher PL2 wattage, multiplier +2 to sustain higher all core clocks (4.8 -> 5.0GHz). Unfortunately my CPU is “potato”, it cannot do higher than 5.0 on all cores, for more than very short benchmark runs.

As far as HW goes, it cannot go any faster, unless I switch to NVENC (I cannot use QSV, due to motherboard), so I started to look at x264 params.

One of the most interesting options is x265 no-rect, I have to do some testing, but it seems to halve slow preset encoding time. Not sure about quality impact yet as there seems to be very little information about it.

@bmcassagne
Copy link

Oh that's a nice setup. I almost bought a new AMD Threadripper, but I have plenty of hard drive space so there's no real reason to hurry. I haven't seen anything from NVENC that approaches the quality vs size of using a CPU. Thought I don't understand why. They're always saying how how amazing video cards are for parallel processing but so far I haven't seen it with video.

@E-t-z
Copy link

E-t-z commented Jan 19, 2021

@bmcassagne Turing supposed to have improved things considerably and I do have RTX2080Ti.

@cdgriffith cdgriffith moved this from Higher Priority to In progress in FastFlix Feb 2, 2021
cdgriffith added a commit that referenced this issue Feb 3, 2021
@cdgriffith
* Adding #166 More robust queue that is recoverable
8aaba50
@cdgriffith cdgriffith moved this from In progress to In Staging in FastFlix Feb 5, 2021
@cdgriffith cdgriffith mentioned this issue Feb 13, 2021
Merged
cdgriffith added a commit that referenced this issue Feb 14, 2021
@cdgriffith
Beta Release 4.2.0b0 (#199)
8e477bb 
* Adding #109 NVENC HEVC support based on FFmpeg
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
@cdgriffith cdgriffith mentioned this issue Apr 13, 2021
Merged
cdgriffith added a commit that referenced this issue Apr 13, 2021
@cdgriffith @SMESH109 @TGMais
Version 4.2.0 (#211)
070e4b8 
* Adding #109 NVENC HEVC support based on FFmpeg (thanks to Zeid164)
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Adding Confirm dialogue for cancel encode and replace currently working on video
* Changing AVC defaults and recommendations for CRF to higher values
* Changing VP9 to default to mkv instead of webm format to support more audio codecs
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing #209 Double spaces were removed in incoming filenames, causing no file found (thanks to stilicrafter)
* Fixing that deinterlace detection could crash program due to CPython bug issue #43423 (thanks to macx)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
* Fixing returning from queue works with duplicated audio tracks

Co-authored-by: SMESH <4199206+smesh109@users.noreply.github.com>
Co-authored-by: TGMais <2453844+tgmais@users.noreply.github.com>
@cdgriffith
Copy link
Owner Author

Added in 4.2.0 https://github.com/cdgriffith/FastFlix/releases/tag/4.2.0

@cdgriffith cdgriffith moved this from In Staging to Done in FastFlix Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New idea for project
Projects
No open projects
FastFlix
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdgriffith @E-t-z @bmcassagne