Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change queue order or delete task from queue since 4.1.0 #176

Closed
E-t-z opened this issue Jan 13, 2021 · 8 comments
Closed

Unable to change queue order or delete task from queue since 4.1.0 #176

E-t-z opened this issue Jan 13, 2021 · 8 comments
Labels
feature request New idea for project
Projects
FastFlix

Comments

@E-t-z
Copy link

E-t-z commented Jan 13, 2021

In version 4.0.4 you were able to reorder/edit/delete items from queue while encoding.
This does not seem to be possible anymore, in version 4.1.0.

It is really annoying that you have to cancel or wait 5-6 (I mostly use 2-pass for my personal videos) hours, until current encode finishes, before you can do any changes in queue.

Maybe this functionality could be restored?
At least Reordering and deleting?
Only thing currently works, is adding new items to the queue.
@cdgriffith cdgriffith added the feature request New idea for project label Jan 13, 2021
@cdgriffith
Copy link
Owner

This will be part of the "more robust" queue system #166

This initial take on it looked to have issues if it was modified in any way after the encoder starts, so had to disable for safety. Current version is that queue system in front end gets modified and sent to backend worker under certain conditions. And then the backend worker doesn't know for sure what order those items are in.

The improved version will probably use a file based queue system so that they both are using the same data set directly

@E-t-z
Copy link
Author

E-t-z commented Jan 13, 2021

Fair enough, thanks 😄

@cdgriffith cdgriffith added this to Higher Priority in FastFlix Jan 13, 2021
@bmcassagne
Copy link

bmcassagne commented Jan 21, 2021 •
edited

PLEASE GO BACK TO QUE SETTINGS OF 4.0.4!! Queue editing seemed to be fine in 4.0.4, other than I had to drop a file on the app to make the queue editable. I'm using 4.1.2, and it's great that I can resize the window but if I want to change a setting on the last encode I added I have to wait a week for the queue to finish??? This feels like a huge downgrade to me. Or was there a big downside that I'm missing?

@E-t-z
Copy link
Author

E-t-z commented Jan 21, 2021

@bmcassagne you could successfully crash it, this way...
For now, I have managed to do it, multiple times and after @cdgriffith comment, it kind of makes sense why.

@bmcassagne
Copy link

Running 3 computers for several weeks I've only had MAYBE one crash. One thing I've noticed though is that the que will look inactive but if you look under "status" there is an encode running. Maybe I'm just doing things in a different order. A crash on a 3 day encode would certainly be annoying.

@E-t-z
Copy link
Author

E-t-z commented Jan 23, 2021

It only crashes, when you mess around with that queue a lot and usually, when it tries to pick next item from queue.
Don't remember exact error message anymore, as UI immediately closes after that.
Was probably something about, job not found, or something like that.

@bmcassagne
Copy link

bmcassagne commented Jan 25, 2021 •
edited

Just to cofirm, there's no easy way to make tasks erasable in the queue?

I guess I'm stuck with 4.0.4 till the new queue system is implemented. 🤷🏽‍♂️

I'm frequently wanting/needing to change some paramater.

@cdgriffith cdgriffith moved this from Higher Priority to In progress in FastFlix Feb 2, 2021
@cdgriffith cdgriffith moved this from In progress to In Staging in FastFlix Feb 5, 2021
@cdgriffith cdgriffith mentioned this issue Feb 13, 2021
Merged
cdgriffith added a commit that referenced this issue Feb 14, 2021
@cdgriffith
Beta Release 4.2.0b0 (#199)
8e477bb 
* Adding #109 NVENC HEVC support based on FFmpeg
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
@cdgriffith cdgriffith mentioned this issue Apr 13, 2021
Merged
cdgriffith added a commit that referenced this issue Apr 13, 2021
@cdgriffith @SMESH109 @TGMais
Version 4.2.0 (#211)
070e4b8 
* Adding #109 NVENC HEVC support based on FFmpeg (thanks to Zeid164)
* Adding NVEenC encoder for HEVC and AVC
* Adding #166 More robust queue that is recoverable
* Adding ability to extract HDR10+ metadata if hdr10plus_parser is detected on path
* Adding #178 selector for number of autocrop positions throughout video (thanks to bmcassagne)
* Adding Windows 10 notification for queue complete success
* Adding #194 fast two pass encoding (thanks to Ugurtan)
* Adding Confirm dialogue for cancel encode and replace currently working on video
* Changing AVC defaults and recommendations for CRF to higher values
* Changing VP9 to default to mkv instead of webm format to support more audio codecs
* Fixing German translations (thanks to SMESH)
* Fixing #171 Be able to select encoder before selecting video
* Fixing #176 Unable to change queue order or delete task from queue since 4.1.0 (thanks to Etz)
* Fixing #185 need to specify channel layout when downmixing (thanks to Ugurtan)
* Fixing #187 cleaning up partial download of FFmpeg (thanks to Todd Wilkinson)
* Fixing #190 add missing chromaloc parameter for x265 (thanks to Etz)
* Fixing #209 Double spaces were removed in incoming filenames, causing no file found (thanks to stilicrafter)
* Fixing that deinterlace detection could crash program due to CPython bug issue #43423 (thanks to macx)
* Fixing that returning item back from queue of a different encoder type would crash Fastflix
* Fixing HDR10 details to be track specific (thanks to Harybo)
* Fixing returning from queue works with duplicated audio tracks

Co-authored-by: SMESH <4199206+smesh109@users.noreply.github.com>
Co-authored-by: TGMais <2453844+tgmais@users.noreply.github.com>
@cdgriffith
Copy link
Owner

Fixed in 4.2.0 https://github.com/cdgriffith/FastFlix/releases/tag/4.2.0

@cdgriffith cdgriffith moved this from In Staging to Done in FastFlix Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New idea for project
Projects
No open projects
FastFlix
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdgriffith @E-t-z @bmcassagne