Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and minor fixes in @Veto section #1

Closed
wants to merge 7 commits into from

Conversation

frenchc
Copy link
Contributor

@frenchc frenchc commented Apr 25, 2013

I have fixed a few typos and fixed minor veto issues.

…ommended list of jpa objects (with Java EE 7 it is possible to use injection in entitylisteners).
@pmuir
Copy link
Contributor

pmuir commented Apr 25, 2013

Actually the annotation is called @Vetoed :-)

On 25 Apr 2013, at 10:42, Jens Schumann notifications@github.com wrote:

I have fixed a few typos and fixed minor veto issues.

You can merge this Pull Request by running

git pull https://github.com/frenchc/cdi-spec.org master
Or view, comment on, or merge it at:

#1

Commit Summary

• Replaced a few @Vetoed, fixed type and removed modellistener from recommended list of jpa objects (with Java EE 7 it is possible to use injection in entitylisteners).
• Typo.
• Added 'Java'
• typo.
• typo.
File Changes

• M faq/what-is-beans-xml-and-why-do-i-need-it.asciidoc (2)
• M faq/why-does-my-normal-scoped-bean-not-get-instantiated-immediately.asciidoc (2)
• M faq/why-is-the-constructor-invoked-twice-when-a-normal-scoped-bean-is-created.asciidoc (2)
• M faq/why-is-veto-a-best-practice-for-persistent-jpa-entities.asciidoc (4)
Patch Links:

https://github.com/cdi-spec/cdi-spec.org/pull/1.patch
https://github.com/cdi-spec/cdi-spec.org/pull/1.diff

@frenchc
Copy link
Contributor Author

frenchc commented Apr 25, 2013

Haha!

And I checked before using http://docs.jboss.org/cdi/api/1.1.EDR1/. Bad luck today. Will fix it.

Jens

Von: Pete Muir <notifications@github.commailto:notifications@github.com>
Antworten an: "cdi-spec/cdi-spec.org" <reply@reply.github.commailto:reply@reply.github.com>
Datum: Donnerstag, 25. April 2013 11:46
An: "cdi-spec/cdi-spec.org" <cdi-spec.org@noreply.github.commailto:cdi-spec.org@noreply.github.com>
Cc: Jens Schumann <jens.schumann@openknowledge.demailto:jens.schumann@openknowledge.de>
Betreff: Re: [cdi-spec.org] Typos and minor fixes in @Veto section (#1)

Actually the annotation is called @Vetoed :-)

On 25 Apr 2013, at 10:42, Jens Schumann <notifications@github.commailto:notifications@github.com> wrote:

I have fixed a few typos and fixed minor veto issues.

You can merge this Pull Request by running

git pull https://github.com/frenchc/cdi-spec.org master
Or view, comment on, or merge it at:

#1

Commit Summary

• Replaced a few @Vetoed, fixed type and removed modellistener from recommended list of jpa objects (with Java EE 7 it is possible to use injection in entitylisteners).
• Typo.
• Added 'Java'
• typo.
• typo.
File Changes

• M faq/what-is-beans-xml-and-why-do-i-need-it.asciidoc (2)
• M faq/why-does-my-normal-scoped-bean-not-get-instantiated-immediately.asciidoc (2)
• M faq/why-is-the-constructor-invoked-twice-when-a-normal-scoped-bean-is-created.asciidoc (2)
• M faq/why-is-veto-a-best-practice-for-persistent-jpa-entities.asciidoc (4)
Patch Links:

https://github.com/cdi-spec/cdi-spec.org/pull/1.patch
https://github.com/cdi-spec/cdi-spec.org/pull/1.diff


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-16997481.

@pmuir
Copy link
Contributor

pmuir commented Apr 25, 2013

:-)

I put the 1.1 FD up on jboss.org - http://docs.jboss.org/cdi/spec/1.1/cdi-spec.html

On 25 Apr 2013, at 10:53, Jens Schumann notifications@github.com wrote:

Haha!

And I checked before using http://docs.jboss.org/cdi/api/1.1.EDR1/. Bad luck today. Will fix it.

Jens

Von: Pete Muir <notifications@github.commailto:notifications@github.com>
Antworten an: "cdi-spec/cdi-spec.org" <reply@reply.github.commailto:reply@reply.github.com>
Datum: Donnerstag, 25. April 2013 11:46
An: "cdi-spec/cdi-spec.org" <cdi-spec.org@noreply.github.commailto:cdi-spec.org@noreply.github.com>
Cc: Jens Schumann <jens.schumann@openknowledge.demailto:jens.schumann@openknowledge.de>
Betreff: Re: [cdi-spec.org] Typos and minor fixes in @Veto section (#1)

Actually the annotation is called @Vetoed :-)

On 25 Apr 2013, at 10:42, Jens Schumann <notifications@github.commailto:notifications@github.com> wrote:

I have fixed a few typos and fixed minor veto issues.

You can merge this Pull Request by running

git pull https://github.com/frenchc/cdi-spec.org master
Or view, comment on, or merge it at:

#1

Commit Summary

• Replaced a few @Vetoed, fixed type and removed modellistener from recommended list of jpa objects (with Java EE 7 it is possible to use injection in entitylisteners).
• Typo.
• Added 'Java'
• typo.
• typo.
File Changes

• M faq/what-is-beans-xml-and-why-do-i-need-it.asciidoc (2)
• M faq/why-does-my-normal-scoped-bean-not-get-instantiated-immediately.asciidoc (2)
• M faq/why-is-the-constructor-invoked-twice-when-a-normal-scoped-bean-is-created.asciidoc (2)
• M faq/why-is-veto-a-best-practice-for-persistent-jpa-entities.asciidoc (4)
Patch Links:

https://github.com/cdi-spec/cdi-spec.org/pull/1.patch
https://github.com/cdi-spec/cdi-spec.org/pull/1.diff


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-16997481.

Reply to this email directly or view it on GitHub.

@frenchc
Copy link
Contributor Author

frenchc commented Apr 25, 2013

Found it, but google didn't;).

Jens

Von: Pete Muir <notifications@github.commailto:notifications@github.com>
Antworten an: "cdi-spec/cdi-spec.org" <reply@reply.github.commailto:reply@reply.github.com>
Datum: Donnerstag, 25. April 2013 11:56
An: "cdi-spec/cdi-spec.org" <cdi-spec.org@noreply.github.commailto:cdi-spec.org@noreply.github.com>
Cc: Jens Schumann <jens.schumann@openknowledge.demailto:jens.schumann@openknowledge.de>
Betreff: Re: [cdi-spec.org] Typos and minor fixes in @Veto section (#1)

:-)

I put the 1.1 FD up on jboss.org - http://docs.jboss.org/cdi/spec/1.1/cdi-spec.html

On 25 Apr 2013, at 10:53, Jens Schumann <notifications@github.commailto:notifications@github.com> wrote:

Haha!

And I checked before using http://docs.jboss.org/cdi/api/1.1.EDR1/. Bad luck today. Will fix it.

Jens

Von: Pete Muir <notifications@github.commailto:notifications@github.commailto:notifications@github.com>
Antworten an: "cdi-spec/cdi-spec.org" <reply@reply.github.commailto:reply@reply.github.commailto:reply@reply.github.com>
Datum: Donnerstag, 25. April 2013 11:46
An: "cdi-spec/cdi-spec.org" <cdi-spec.org@noreply.github.commailto:cdi-spec.org@noreply.github.commailto:cdi-spec.org@noreply.github.com>
Cc: Jens Schumann <jens.schumann@openknowledge.demailto:jens.schumann@openknowledge.demailto:jens.schumann@openknowledge.de>
Betreff: Re: [cdi-spec.org] Typos and minor fixes in @Veto section (#1)

Actually the annotation is called @Vetoed :-)

On 25 Apr 2013, at 10:42, Jens Schumann <notifications@github.commailto:notifications@github.commailto:notifications@github.com> wrote:

I have fixed a few typos and fixed minor veto issues.

You can merge this Pull Request by running

git pull https://github.com/frenchc/cdi-spec.org master
Or view, comment on, or merge it at:

#1

Commit Summary

• Replaced a few @Vetoed, fixed type and removed modellistener from recommended list of jpa objects (with Java EE 7 it is possible to use injection in entitylisteners).
• Typo.
• Added 'Java'
• typo.
• typo.
File Changes

• M faq/what-is-beans-xml-and-why-do-i-need-it.asciidoc (2)
• M faq/why-does-my-normal-scoped-bean-not-get-instantiated-immediately.asciidoc (2)
• M faq/why-is-the-constructor-invoked-twice-when-a-normal-scoped-bean-is-created.asciidoc (2)
• M faq/why-is-veto-a-best-practice-for-persistent-jpa-entities.asciidoc (4)
Patch Links:

https://github.com/cdi-spec/cdi-spec.org/pull/1.patch
https://github.com/cdi-spec/cdi-spec.org/pull/1.diff


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-16997481.

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-16997902.

@frenchc
Copy link
Contributor Author

frenchc commented Apr 25, 2013

Fixed Vetoed.

@pmuir
Copy link
Contributor

pmuir commented Apr 25, 2013

Thanks, merged!

@pmuir pmuir closed this Apr 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants