-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] - Add async serdes.deserialize support & req/res as context #749
Open
macyabbey-okta
wants to merge
25
commits into
cdimascio:master
Choose a base branch
from
askspoke:macya-context-and-async
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2954777
[feat] - Async deserialization and req/res as
macyabbey-okta 669f03b
Capture knowledge gained on how the package works, thoughts and struc…
macyabbey-okta dcf40fb
Self code review. Cleaning up comments. Single module async-utils. Mo…
macyabbey-okta 273069d
Impl and test coverage for what is expected when async deserialize th…
macyabbey-okta f6ba222
Fix mermaid
macyabbey-okta e50c9d6
Add npm run test:base to make it easier to target specific tests.
macyabbey-okta d5a1bc2
Remove not-needed change to non-async serdes error handling which als…
macyabbey-okta c84bbc7
Let sync deserialize/serialize influence error messages too.
macyabbey-okta 50fea82
Fixing gaps in schema traversal (oneOf/allOf/anyOf/items)
macyabbey-okta da67f24
More coverage for updating schema with in case of XOF/array/items.
macyabbey-okta 9e9b302
Fixing bug with async and context support when XOF has an async sub-s…
macyabbey-okta c609e86
Fix bug where instancePath of schemas in a request body where top lev…
macyabbey-okta e5980a9
Convenience for trigger debug
macyabbey-okta 445f165
Remove spread operators.
macyabbey-okta 6be17fa
Squash validation messages from oneOf sub-schemas that do not match t…
macyabbey-okta 94bde72
Allowing new option 'filterOneOf' to pair down errors thrown by oneOf…
macyabbey-okta b5058be
Fix handling of items in a schema, better typing.
macyabbey-okta 5e1c573
Handling no items case properly
macyabbey-okta 3d25af8
Use most specific oneOf subschema
macyabbey-okta 8125da9
De-duping errors for same keyword/path combinations.
macyabbey-okta d99cd04
If schema has discriminator and a default, apply default values to th…
macyabbey-okta 9bc3885
Fix slice to get ref to component schema
macyabbey-okta d03c2a6
Let HttpErrors thrown from serdes surface with error name as keyword …
macyabbey-okta fb72ff1
check for object in discriminator validation
colinwang-okta 349a0b9
check if oneOf entry is actually type object
colinwang-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems off; how can a response be validated before a handler has an opportunity to generate it?