Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Name field of GlobalReference could be a String #23

Closed
langston-barrett opened this issue Nov 22, 2022 · 2 comments
Closed

The Name field of GlobalReference could be a String #23

langston-barrett opened this issue Nov 22, 2022 · 2 comments

Comments

@langston-barrett
Copy link
Contributor

The GlobalReference constant has a Name field, where Name is a sum of u64 and String. I believe global variables and functions always have actual names, rather than numbers - perhaps the Name field of GlobalReference could be specialized to String?
@cdisselkoen
Copy link
Owner

You are right. Let's specialize

@langston-barrett langston-barrett mentioned this issue Dec 23, 2022
Closed
@cdisselkoen cdisselkoen mentioned this issue Sep 1, 2023
Closed
cdisselkoen added a commit that referenced this issue Sep 7, 2023
@cdisselkoen
Revert #23, #26, and #33. Global values' names are Name not String
fc5672e 
Specifically, reverts:
- commit 1c53f8a (#23)
- commit 47c895d (#26)
- commit 94bb32c (#33)

Fixes #42.
@cdisselkoen
Copy link
Owner

Reverted this after discussion on #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langston-barrett @cdisselkoen