Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Name field of GlobalVariable could be a String #26

Closed
langston-barrett opened this issue Dec 23, 2022 · 4 comments
Closed

The Name field of GlobalVariable could be a String #26

langston-barrett opened this issue Dec 23, 2022 · 4 comments

Comments

@langston-barrett
Copy link
Contributor

Same comment as #23, global variables always have actual names.
@cdisselkoen
Copy link
Owner

Does the resolution of #23 (1c53f8a) not address the issue?

@langston-barrett
Copy link
Contributor Author

langston-barrett commented Jan 3, 2023 •
edited
Loading

It looks to me like GlobalVariable has a Name field:

llvm-ir/src/module.rs

Line 141 in 552d11e

pub name: Name,

where Name has a Number constructor, which, IIUC, can never be used for a global variable in a well-formed LLVM module.

llvm-ir/src/name.rs

Line 16 in 552d11e

Number(usize),

Looks like 1c53f8a fixed an analogous issue for GlobalReference, but didn't touch GlobalVariable.

@cdisselkoen
Copy link
Owner

Thanks for this report. Fixed on main now

@langston-barrett langston-barrett mentioned this issue Feb 5, 2023
Closed
@cdisselkoen cdisselkoen mentioned this issue Sep 1, 2023
Closed
cdisselkoen added a commit that referenced this issue Sep 7, 2023
@cdisselkoen
Revert #23, #26, and #33. Global values' names are Name not String
fc5672e 
Specifically, reverts:
- commit 1c53f8a (#23)
- commit 47c895d (#26)
- commit 94bb32c (#33)

Fixes #42.
@cdisselkoen
Copy link
Owner

Reverted this after discussion on #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langston-barrett @cdisselkoen