Fixed a PMD warning: removed an underscore from a non-final var

Change-Id: I22f17b64ebb97b605402b6636bfa02be5fcb1ac9 Signed-off-by: John May <john.wilkinsonmay@gmail.com>
cdk · Dec 15, 2014 · 5282618 · 5282618
1 parent ceef23c
commit 5282618
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/...ic/src/main/java/org/openscience/cdk/qsar/descriptors/atomic/RDFProtonDescriptor_G3R.java b/...ic/src/main/java/org/openscience/cdk/qsar/descriptors/atomic/RDFProtonDescriptor_G3R.java
@@ -437,12 +437,12 @@ && getIfBondIsNotRotatable(mol,
             position = 0;
             smooth = -2.86;
             angle = 0;
-            int ya_counter = 0;
+            int yaCounter = 0;
             List<IAtom> connAtoms;
             for (double g3r = 0; g3r < limitSup; g3r = g3r + step) {
                 sum = 0;
                 for (Integer aBondsInCycloex : bondsInCycloex) {
-                    ya_counter = 0;
+                    yaCounter = 0;
                     angle = 0;
                     partial = 0;
                     position = aBondsInCycloex;
@@ -452,10 +452,10 @@ && getIfBondIsNotRotatable(mol,
 
                     connAtoms = mol.getConnectedAtomsList(cycloexBondAtom0);
                     for (IAtom connAtom : connAtoms) {
-                        if (connAtom.equals(neighbour0)) ya_counter += 1;
+                        if (connAtom.equals(neighbour0)) yaCounter += 1;
                     }
 
-                    if (ya_counter > 0) {
+                    if (yaCounter > 0) {
                         aA.set(cycloexBondAtom1.getPoint3d().x, cycloexBondAtom1.getPoint3d().y,
                                 cycloexBondAtom1.getPoint3d().z);
                         aB.set(cycloexBondAtom0.getPoint3d().x, cycloexBondAtom0.getPoint3d().y,

diff --git a/storage/io/src/main/java/org/openscience/cdk/io/pubchemxml/PubChemXMLHelper.java b/storage/io/src/main/java/org/openscience/cdk/io/pubchemxml/PubChemXMLHelper.java
@@ -233,8 +233,8 @@ public void parserAtomBlock(XmlPullParser parser, IAtomContainer molecule) throw
     }
 
     public void parserCompoundInfoData(XmlPullParser parser, IAtomContainer molecule) throws Exception {
-        String urn_label = null;
-        String urn_name = null;
+        String urnLabel = null;
+        String urnName = null;
         String sval = null;
         while (parser.next() != XmlPullParser.END_DOCUMENT) {
             if (parser.getEventType() == XmlPullParser.END_TAG) {
@@ -243,9 +243,9 @@ public void parserCompoundInfoData(XmlPullParser parser, IAtomContainer molecule
                 }
             } else if (parser.getEventType() == XmlPullParser.START_TAG) {
                 if (EL_PROPS_URNNAME.equals(parser.getName())) {
-                    urn_name = parser.nextText();
+                    urnName = parser.nextText();
                 } else if (EL_PROPS_URNLABEL.equals(parser.getName())) {
-                    urn_label = parser.nextText();
+                    urnLabel = parser.nextText();
                 } else if (EL_PROPS_SVAL.equals(parser.getName())) {
                     sval = parser.nextText();
                 } else if (EL_PROPS_FVAL.equals(parser.getName())) {
@@ -255,8 +255,8 @@ public void parserCompoundInfoData(XmlPullParser parser, IAtomContainer molecule
                 }
             }
         }
-        if (urn_label != null & sval != null) {
-            String property = urn_label + (urn_name == null ? "" : " (" + urn_name + ")");
+        if (urnLabel != null & sval != null) {
+            String property = urnLabel + (urnName == null ? "" : " (" + urnName + ")");
             molecule.setProperty(property, sval);
         }
     }