[bug:1275] added check to ensure that when String.substring is called…

… the string is long enough
cdk · Nov 7, 2012 · 5a7baa4 · 5a7baa4
1 parent 0e97eff
commit 5a7baa4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java b/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java
@@ -555,9 +555,11 @@ else if (att.equals("occupancy")) {
         } else if ("bondStereo".equals(name)) {
             for (int i = 0; i < atts.getLength(); i++) {
                 if (atts.getQName(i).equals("dictRef")) {
-                	if (atts.getValue(i).startsWith("cml:"))
-                	bondStereo.add(atts.getValue(i).substring(4));
-                    stereoGiven=true;
+                    String value = atts.getValue(i);
+                	if (value.startsWith("cml:") && value.length() > 4) {
+                	    bondStereo.add(value.substring(4));
+                        stereoGiven=true;
+                    }
                 }
             }
         } else if ("bondType".equals(name)) {