Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sgroup #149

Closed
wants to merge 6 commits into from
Closed

Sgroup #149

wants to merge 6 commits into from

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Sep 4, 2015

Adds preliminary support for Molfile Sgroups. Currently only round tripping and rendering. Rendering is limited to polymer brackets but I plan on adding the other rendering parts later this week.

Lots more todo but gives us a start. I've wanted to add this for some time and meeting Venkat at the ACS he said they couldn't use CDK in ChEBI because it didn't display Sgroups.

Molfile SRU example

… specific API (need interfaces) may be added in future.
…point,SBV=bond vector) we don't yet handle. We can store whether an Sgroup is expanded easily but the others will need additional classes. Since these only seem to be used by more complex (e.g. peptide) contractions they are ommitted for now.
@egonw
Copy link
Member

egonw commented Sep 6, 2015

Never mind my comments... they are not requests. Code looks good. I will now try to apply it locally.

@egonw
Copy link
Member

egonw commented Sep 6, 2015

Applied (rebased) and pushed.

@egonw egonw closed this Sep 6, 2015
@johnmay johnmay deleted the sgroup branch September 6, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants