Integer overflow when parsing atom count in molecular formula #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's the way it is for speed, I don't think the solution of using the slower API call and catching the exception is better, you still end up with a negative number. Nicer would be to just check if the value overflows |
|
I have replaced API call with manual overflow checking. |
egonw
requested changes
Sep 4, 2021
|
|
||
| @Test public void atomCountIsSafeForOverflow() { | ||
| // max integer | ||
| assertFormulaContainsExactlyAtoms(getMolecularFormula("H2147483647", builder), Integer.MAX_VALUE); |
There was a problem hiding this comment.
I don't understand this test. Should there not 2147483647 atoms here?
|
Looking back at this I think the simpler solution is to cap the atom count at some upper limit (e.g. 1 million) which is more than enough. TITIN is 35k amino acids https://en.wikipedia.org/wiki/Titin |
|
Now #808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.