Replace atom Symbol with Integer constant comparison #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re convient if these are ints rather than bytes.
|
Will look at the sonar cloud issues - expected since this touched a lot of classes |
…he original paper we see this is meant to be the SQRT(RADII) where this is different for each atom type.
|
Kudos, SonarCloud Quality Gate passed! |
|
Thanks. Looks good. This was not possible in the past, because atomic numbers were not automatically set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta catch em all... I think I got the vast majority of them. Resolves #546
I do wonder longer (CDK v3.0/v4.0) term if may making it just store and compare the enum.
Mainly because interface constants are a bit of a bad pattern but it is quite handy.