New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute correct HuLuIndex values and add a test case for a closed bug… #832
Conversation
We closed #737 accidentally it seems - I remember there was some other bug with it though so managed to track it down. |
/* | ||
* ===================================== | ||
* Copyright (c) 2022 NextMove Software | ||
* ===================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright NextMove is fine. Please use the common format with the license, tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry just the default in the IDE :-)
@rajarshi, may I invite you to have a quick look at this patch too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nothing obvious jumped out to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnmay, okay, the code is good to go, but there is a now a conflict. I had a quick look, but I think it's better you resolve it, since you have your conflicting (code clean up) patch fresh in your mind.
thanks! |
Will rebase |
d1c6005
to
ba422bd
Compare
Okay rebased - should be good but will wait for build |
Kudos, SonarCloud Quality Gate passed! |
… that still existed.
Fixes #737 and #830.