Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiContactDescriptor #833

Merged
merged 2 commits into from Feb 9, 2022
Merged

PiContactDescriptor #833

merged 2 commits into from Feb 9, 2022

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Feb 8, 2022

Fixes #509 - there was an obvious bug as atoms were cloned. The test needed from the bug report updating slightly.

…iour) and add document that pi-systems with a single double bond are not considered conjugated.
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@k-ujihara
Copy link
Contributor

Thanks @johnmay it looks good.
I consider that we may add compounds containing aromatic bonds, such as styrene, to test case.

@egonw egonw merged commit 1d71596 into master Feb 9, 2022
@egonw
Copy link
Member

egonw commented Feb 9, 2022

I'm good too.

@johnmay johnmay deleted the patch/picontact-fixes branch February 9, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiContactDetectionDescriptor doesn't work correctly
3 participants