Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a corner case in repeat crossing bonds when we have variable atta… #835

Merged
merged 3 commits into from Feb 12, 2022
Merged

Fix a corner case in repeat crossing bonds when we have variable atta… #835

merged 3 commits into from Feb 12, 2022

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Feb 9, 2022

…chments.

Fixes cdk/depict#26

@johnmay johnmay mentioned this pull request Feb 9, 2022
Closed
egonw
egonw requested changes Feb 9, 2022
View reviewed changes
base/standard/src/main/java/org/openscience/cdk/fingerprint/GraphOnlyFingerprinter.java Outdated
/*
* =====================================
* Copyright (c) 2022 NextMove Software
* =====================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps :-)

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

johnmay
johnmay commented Feb 9, 2022
View reviewed changes
Copy link
Member Author

@johnmay johnmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@egonw egonw merged commit b8aea4f into master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonw egonw egonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Salt overlapping bond
2 participants
@johnmay @egonw