Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FreeHepWrapper.java #851

Merged
merged 1 commit into from Apr 7, 2022
Merged

Update FreeHepWrapper.java #851

merged 1 commit into from Apr 7, 2022

Conversation

OBrink
Copy link
Contributor

@OBrink OBrink commented Apr 6, 2022

Typo correction

@egonw egonw self-requested a review April 6, 2022 12:14
@egonw
Copy link
Member

egonw commented Apr 6, 2022

@johnmay, this one is a simple typo fix. Sonarcloud fails, because it doesn't work on remote branches,

@johnmay johnmay merged commit 67daab2 into cdk:master Apr 7, 2022
@johnmay
Copy link
Member

johnmay commented Apr 7, 2022

I am curious of the solution there - should we just put the key in bare in the YAML config?

@egonw
Copy link
Member

egonw commented Apr 7, 2022

Not sure... we should be able to google this. I'll do some searching this week.

@johnmay
Copy link
Member

johnmay commented Apr 7, 2022

It does seem to be setup correctly - or how SonarCloud document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonw egonw egonw approved these changes

Assignees

@johnmay johnmay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OBrink @egonw @johnmay