Catch more specific Exception in LoggingTool #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception to avoid just swallowing all exceptions that might occur
|
First contribution in a long time! Happy to come up with more in the future 😃 |
|
Something to note is you can now do this property switching logic in the Log4j XML config. Because of course you can :-). This logic was more just to make it easy to flip on/off verbose logging since no one got time to write an XML file just to turn debugging on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching the more specific
SecurityExceptioninstead of the generalExceptionto avoid just swallowing all exceptions that might occur.Discussed with @egonw in #873, more specifically at the end of this comment.