Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on the large molecules flag in InChI Universal SMILES numbers. #979

Merged
merged 4 commits into from Jun 23, 2023

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Jun 20, 2023

Fixes #974

@johnmay
Copy link
Member Author

johnmay commented Jun 20, 2023

Whoops I forgot the workflows run with a smaller stack... could increase the stack or use a smaller example :-)

@johnmay
Copy link
Member Author

johnmay commented Jun 20, 2023

Grr... ok -Xss needed :-)

@johnmay
Copy link
Member Author

johnmay commented Jun 21, 2023

Hi @mjw99 do you know how to change the JVM stack size in the github workflow? I thought I could just put it in MAVEN_OPTS: but this doesn't seem to be the case.

@johnmay
Copy link
Member Author

johnmay commented Jun 23, 2023

OK we good now, surefire (maven test engine) argLine did the trick.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@egonw
Copy link
Member

egonw commented Jun 23, 2023

nevermind, it's small :)

@@ -88,6 +89,28 @@ void bispropenyloctatriene() throws Exception {
"C\\C=C/C(/C=C/C)=C(/C=C/C)\\C=C/C");
}

@Test
public void testLargeMoleculeCanon() throws CDKException {
SmilesParser smipar = new SmilesParser(DefaultChemObjectBuilder.getInstance());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually, it's a really small patch.

Is the use of the DefaultChemObjectBuilder important here?

@egonw egonw merged commit 0f46285 into main Jun 23, 2023
6 checks passed
@mjw99
Copy link
Contributor

mjw99 commented Jul 11, 2023

Hi @mjw99 do you know how to change the JVM stack size in the github workflow? I thought I could just put it in MAVEN_OPTS: but this doesn't seem to be the case.

Apologies, I've only just seen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InChi LargeMolecules Switch
3 participants