New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on the large molecules flag in InChI Universal SMILES numbers. #979
Conversation
Whoops I forgot the workflows run with a smaller stack... could increase the stack or use a smaller example :-) |
Grr... ok -Xss needed :-) |
Hi @mjw99 do you know how to change the JVM stack size in the github workflow? I thought I could just put it in |
OK we good now, surefire (maven test engine) argLine did the trick. |
Kudos, SonarCloud Quality Gate passed! |
nevermind, it's small :) |
@@ -88,6 +89,28 @@ void bispropenyloctatriene() throws Exception { | |||
"C\\C=C/C(/C=C/C)=C(/C=C/C)\\C=C/C"); | |||
} | |||
|
|||
@Test | |||
public void testLargeMoleculeCanon() throws CDKException { | |||
SmilesParser smipar = new SmilesParser(DefaultChemObjectBuilder.getInstance()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, actually, it's a really small patch.
Is the use of the DefaultChemObjectBuilder
important here?
Apologies, I've only just seen this. |
Fixes #974