fix!: respect hyphens in helm chart names #1666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rassie
force-pushed
the
handle-kebab-case
branch
from
08db18b
to
2567468
Compare
From `json2jsii` 0.4.0 onwards, type name sanitization works correctly with kebab case, i.e. it no longer ignores hyphens, so that names like `ingress-nginx`, which previously have been previously converted to `Ingressnginx`, now get converted to `IngressNginx`, which is the expected behaviour for kebab case to pascal case conversion. However, `cdk8s-cli`'s helm import has been additionally sanitizing hyphens in chart names, even though hyphens are valid characters in chart names, so that the change in `json2jsii` had no effect. This patch simplifies the helm importer's sanitization routine to not remove hyphens anymore, resulting in more correct class names. Signed-off-by: Nikolai Prokoschenko <nikolai.prokoschenko@kurzdigital.com>
rassie
force-pushed
the
handle-kebab-case
branch
from
2567468
to
6f782a4
Compare
|
cc @vinayak-kukreja, since you are the author of the original patch |
|
Hey @rassie, thank you for opening a contribution with us and apologies for the delay. I am not sure if we can accept a breaking change. Probably would need to be behind some kind of feature flag. Let me consult the team and get back to you. |
|
https://github.com/cdk8s-team/cdk8s-cli/pull/1737/files was a breaking change to the same effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
json2jsii0.4.0 onwards, type name sanitization works correctly with kebab case, i.e. it no longer ignores hyphens, so that names likeingress-nginx, which previously have been previously converted toIngressnginx, now get converted toIngressNginx, which is the expected behaviour for kebab case to pascal case conversion. However,cdk8s-cli's helm import has been additionally sanitizing hyphens in chart names, even though hyphens are valid characters in chart names, so that the change injson2jsiihad no effect. This patch simplifies the helm importer's sanitization routine to not remove hyphens anymore, resulting in more correct class names.This will be a breaking change for people using Helm charts with a hyphen in the name.