fix!: kebab-cases type names not correctly converted to PascalCase #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rassie
changed the title
In kebab-case, the dash character is supposed to separate words, which is currently not reflected in `normalizeTypeName`. Currently, kebab-cased type names like "name-type" are converted to "Nametype" instead of more expected "NameType". This patch adds a pre-processing step which handles kebab-case first. Signed-off-by: Nikolai Prokoschenko <nikolai.prokoschenko@kurzdigital.com>
auto-merge was automatically disabled
November 7, 2023 08:26
Head branch was pushed to by a user without write access
mrgrain
changed the title
mrgrain
changed the title
mrgrain
approved these changes
Nov 16, 2023
mrgrain
changed the title
|
Thanks for this! Nice find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kebab-case, the dash character is supposed to separate words, which is currently not reflected in
normalizeTypeName. Currently, kebab-cased type names like "name-type" are converted to "Nametype" instead of more expected "NameType". This patch adds a pre-processing step which handles kebab-case first.BREAKING CHANGE: kebab-cased type names like
name-typewere converted toNametype. Now they are converted toNameType.