fix: code generating enum values containing !, =, ~ are stripped

[vinayak-kukreja]

This has been fixed in json2jsii. Allowlisting characters !, =, ~.

Fixes #229

[vinayak-kukreja]

These are now working. Unfortunately the diff is huge so it does not show up in the web ui. But, you can take this locally and verify it.

This is what it looks now,

/**
 * Match operation available with AlertManager >= v0.22.0 and takes precedence over Regex (deprecated) if non-empty.
 *
 * @schema AlertmanagerConfigSpecInhibitRulesSourceMatchMatchType
 */
export enum AlertmanagerConfigSpecInhibitRulesSourceMatchMatchType {
  /** != */
  VALUE_NOT_EQUALS_TO = \\"!=\\",
  /** = */
  VALUE_ = \\"=\\",
  /** =~ */
  VALUE_EQUAL_TILDE = \\"=~\\",
  /** !~ */
  VALUE_NEGATION_TILDE = \\"!~\\",
}

[vinayak-kukreja]

VALUE_ = \\"=\\",

Fixing this in Json2Jsii now

[paulhcsun]

What is the purpose of this file?

[vinayak-kukreja]

So this is a Custom Resource Definition that is failing in the issue mentioned. We can add these to the tests and they create a snapshot that we can verify if the generated code is as expected.

This CRD was failing code generation due to symbols that were not handled correctly by Json2Jsii. So I fixed that first and then allowlisted these in cdk8s.

Since = was missed, the code generation just gave us VALUE_ which is incorrect. So I will update the json2jsii version with the fix you just approved and that should fix this. Until then we cannot merge this.

[paulhcsun]

lgtm, thanks for explaining. Added a do-not-merge tag, feel free to remove and merge once json2jsii version is updated

[vinayak-kukreja]

Great, thank you.

After the update it is,

/**
 * Match operation available with AlertManager >= v0.22.0 and takes precedence over Regex (deprecated) if non-empty.
 *
 * @schema AlertmanagerConfigSpecInhibitRulesSourceMatchMatchType
 */
export enum AlertmanagerConfigSpecInhibitRulesSourceMatchMatchType {
  /** != */
  VALUE_NOT_EQUALS_TO = \\"!=\\",
  /** = */
  VALUE_EQUALS = \\"=\\",
  /** =~ */
  VALUE_EQUAL_TILDE = \\"=~\\",
  /** !~ */
  VALUE_NEGATION_TILDE = \\"!~\\",
}

[cdk8s-automation]

💚 All backports created successfully

Status	Branch	Result
✅	1.x

Questions ?

Please refer to the Backport tool documentation