Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make output files extension configurable #296

Closed
heckler1 opened this issue Jan 27, 2022 · 0 comments · Fixed by #297
Closed

Make output files extension configurable #296

heckler1 opened this issue Jan 27, 2022 · 0 comments · Fixed by #297

Comments

@heckler1
Copy link
Contributor

This is something that would be useful for our use case, as it removes the need for renaming files to match existing manifests as a secondary step.
@heckler1 heckler1 mentioned this issue Jan 27, 2022
Merged
@mergify mergify bot closed this as completed in #297 Jan 28, 2022
mergify bot pushed a commit that referenced this issue Jan 28, 2022
@heckler1
feat: Allow configuration of output YAML file extensions (#297)
14742f2 
Fixes #296 

I've retained the current behavior as the default, and added a prop to `App` to allow configuration of the file extensions applied to the outputted YAML.

Please just let me know if you'd like any more information or if I need to make any changes!
Chriscbr pushed a commit that referenced this issue Jan 28, 2022
@heckler1 @Chriscbr
feat: Allow configuration of output YAML file extensions (#297)
c5d6bec 
Fixes #296 

I've retained the current behavior as the default, and added a prop to `App` to allow configuration of the file extensions applied to the outputted YAML.

Please just let me know if you'd like any more information or if I need to make any changes!
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>
Chriscbr added a commit that referenced this issue Jan 28, 2022
@Chriscbr @heckler1
feat: Allow configuration of output YAML file extensions (#297) (#300)
e82b443 
Fixes #296 

I've retained the current behavior as the default, and added a prop to `App` to allow configuration of the file extensions applied to the outputted YAML.

Please just let me know if you'd like any more information or if I need to make any changes!
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>

Co-authored-by: S Heckler <55748928+heckler1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow configuration of output YAML file extensions heckler1/cdk8s-core
1 participant
@heckler1