Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Env var from fieldRef/resource support #263

Merged
merged 2 commits into from
Jan 18, 2022
Merged

feat: Env var from fieldRef/resource support #263

merged 2 commits into from
Jan 18, 2022

Conversation

ambasta
Copy link
Contributor

@ambasta ambasta commented Jan 13, 2022

Initial work to add EnvVars from fieldRef and resourceFieldRef.

ToDo:

  • Write test cases.

Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one comment about the API

src/container.ts Outdated Show resolved Hide resolved
Signed-off-by: Amit Prakash Ambasta <amit.prakash.ambasta@gmail.com>
@ambasta ambasta requested a review from Chriscbr January 17, 2022 15:28
@mergify mergify bot merged commit 650096f into cdk8s-team:k8s-22/main Jan 18, 2022
Chriscbr added a commit that referenced this pull request Jan 19, 2022
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>
Chriscbr added a commit that referenced this pull request Jan 19, 2022
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants