Merge pull request gettalong#5 from jacius/span

span tags must have a separate closing tag to be valid HTML.
cdlm · Sep 24, 2011 · 3a72b72 · 3a72b72
2 parents e6c1b12 + df5e705
commit 3a72b72
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/kramdown/converter/html.rb b/lib/kramdown/converter/html.rb
@@ -178,7 +178,7 @@ def convert_dt(el, indent)
       end
 
       # A list of all HTML tags that need to have a body (even if the body is empty).
-      HTML_TAGS_WITH_BODY=['div', 'script', 'iframe', 'textarea', 'a'] # :nodoc:
+      HTML_TAGS_WITH_BODY=['div', 'span', 'script', 'iframe', 'textarea', 'a'] # :nodoc:
 
       def convert_html_element(el, indent)
         res = inner(el, indent)

diff --git a/test/testcases/span/05_html/normal.html b/test/testcases/span/05_html/normal.html
@@ -15,7 +15,9 @@
 <p>This is <span>tag
 </span> now.</p>
 
-<p>This is <em>something<span test="do_it" /> strange</em>.</p>
+<p>This is an empty <span></span> tag.</p>
+
+<p>This is <em>something<span test="do_it"></span> strange</em>.</p>
 
 <p>Auto-closing: <br /></p>
 

diff --git a/test/testcases/span/05_html/normal.text b/test/testcases/span/05_html/normal.text
@@ -15,6 +15,8 @@ now </span>.
 This is <span>tag
 </span> now.
 
+This is an empty <span></span> tag.
+
 This is _something<span test="do_it" /> strange_.
 
 Auto-closing: <br>