migrated sync context to use weak ref for events; resolves #308

Manatee.Trello.UnitTests/DevTest.cs

@@ -21,7 +21,7 @@
 namespace Manatee.Trello.UnitTests
 {
 	[TestFixture]
-	[Ignore("This test fixture for development purposes only.")]
+	//[Ignore("This test fixture for development purposes only.")]
 	public class DevTest
 	{
 		private readonly TrelloFactory _factory = new TrelloFactory();
@@ -41,7 +41,7 @@ await Run(async ct =>
 						watch.Stop();
 						Console.WriteLine(watch.ElapsedMilliseconds);
 						Console.WriteLine();
-						//TrelloConfiguration.Cache.Clear();
+						TrelloConfiguration.Cache.Clear();
 					}
 				});
 		}

Manatee.Trello.UnitTests/Internal/Synchronization/SynchronizedContextTests.cs

@@ -143,7 +143,7 @@ public async Task SynchronizeRaisesSynchronizedEvent()
 					{
 						NewData = new SynchronizedData {Test = "one"}
 					};
-				target.Synchronized += properties => counter++;
+				target.PublicSynchronized += properties => counter++;
 
 				await target.Synchronize(false, CancellationToken.None);
 
@@ -195,7 +195,7 @@ public void MergeRaisesSynchronizedEvent()
 				{
 					NewData = new SynchronizedData {Test = "one"}
 				};
-			target.Synchronized += properties => counter++;
+			target.PublicSynchronized += properties => counter++;
 
 			target.Merge(new SynchronizedData {Test = "two"});
 
@@ -226,7 +226,7 @@ public async Task CancelUpdatePreventsSubmittingPendingChanges()
 		}
 
 		[Test]
-		public async Task DependantContextRequestsChangeTriggersSubmission()
+		public async Task DependentContextRequestsChangeTriggersSubmission()
 		{
 			MockHost.MockJson();
 			MockHost.JsonFactory.Setup(f => f.Create<SynchronizedData>())

Manatee.Trello.UnitTests/Internal/Synchronization/SynchronizedObject.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
 using Manatee.Trello.Internal.DataAccess;
@@ -15,6 +16,8 @@ internal class SynchronizedObject : SynchronizationContext<SynchronizedData>
 		public SynchronizedData NewData { get; set; }
 		public bool SupportsUpdates { get; set; } = true;
 
+		public event Action<List<string>> PublicSynchronized;
+
 		static SynchronizedObject()
 		{
 			Properties = new Dictionary<string, Property<SynchronizedData>>
@@ -70,5 +73,11 @@ protected override bool CanUpdate()
 		{
 			return SupportsUpdates;
 		}
+
+		protected override void OnMerged(List<string> properties)
+		{
+			PublicSynchronized?.Invoke(properties);
+			base.OnMerged(properties);
+		}
 	}
 }

Manatee.Trello/Action.cs

@@ -14,7 +14,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents an action performed on Trello objects.
 	/// </summary>
-	public class Action : IAction, IMergeJson<IJsonAction>, IBatchRefresh
+	public class Action : IAction, IMergeJson<IJsonAction>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for actions.
@@ -226,7 +226,7 @@ public Action(string id, TrelloAuthorization auth = null)
 		{
 			Id = id;
 			_context = new ActionContext(id, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 
 			_creator = new Field<Member>(_context, nameof(Creator));
 			_date = new Field<DateTime?>(_context, nameof(Date));
@@ -290,7 +290,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/Attachment.cs

@@ -15,7 +15,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents an attachment to a card.
 	/// </summary>
-	public class Attachment : IAttachment, IMergeJson<IJsonAttachment>, IBatchRefresh
+	public class Attachment : IAttachment, IMergeJson<IJsonAttachment>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for attachments.
@@ -198,7 +198,7 @@ internal Attachment(IJsonAttachment json, string ownerId, TrelloAuthorization au
 		{
 			Id = json.Id;
 			_context = new AttachmentContext(Id, ownerId, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 
 			_bytes = new Field<int?>(_context, nameof(Bytes));
 			_date = new Field<DateTime?>(_context, nameof(Date));
@@ -264,7 +264,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/Board.cs

@@ -15,7 +15,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a board.
 	/// </summary>
-	public class Board : IBoard, IMergeJson<IJsonBoard>, IBatchRefresh
+	public class Board : IBoard, IMergeJson<IJsonBoard>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for boards.
@@ -376,7 +376,7 @@ static Board()
 		public Board(string id, TrelloAuthorization auth = null)
 		{
 			_context = new BoardContext(id, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 			Id = id;
 
 			_description = new Field<string>(_context, nameof(Description));
@@ -470,7 +470,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			if (Id != _context.Data.Id)
 			{

Manatee.Trello/BoardMembership.cs

@@ -13,7 +13,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents the permission level a member has on a board.
 	/// </summary>
-	public class BoardMembership : IBoardMembership, IMergeJson<IJsonBoardMembership>, IBatchRefresh
+	public class BoardMembership : IBoardMembership, IMergeJson<IJsonBoardMembership>, IBatchRefresh, IHandleSynchronization
 	{
 		private readonly Field<Member> _member;
 		private readonly Field<BoardMembershipType?> _memberType;
@@ -70,7 +70,7 @@ internal BoardMembership(IJsonBoardMembership json, string ownerId, TrelloAuthor
 		{
 			Id = json.Id;
 			_context = new BoardMembershipContext(Id, ownerId, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 
 			_member = new Field<Member>(_context, nameof(Member));
 			_memberType = new Field<BoardMembershipType?>(_context, nameof(MemberType));
@@ -117,7 +117,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/Card.cs

@@ -15,7 +15,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a card.
 	/// </summary>
-	public class Card : ICard, IMergeJson<IJsonCard>, IBatchRefresh
+	public class Card : ICard, IMergeJson<IJsonCard>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for cards.
@@ -426,7 +426,7 @@ public Card(string id, TrelloAuthorization auth = null)
 		{
 			Id = id;
 			_context = new CardContext(id, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 
 			Badges = new Badges(_context.BadgesContext);
 			_board = new Field<Board>(_context, nameof(Board));
@@ -521,7 +521,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			if (Id != _context.Data.Id)
 			{

Manatee.Trello/CheckItem.cs

@@ -15,7 +15,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a checklist item.
 	/// </summary>
-	public class CheckItem : ICheckItem, IMergeJson<IJsonCheckItem>, IBatchRefresh
+	public class CheckItem : ICheckItem, IMergeJson<IJsonCheckItem>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for check items.
@@ -150,7 +150,7 @@ internal CheckItem(IJsonCheckItem json, string checkListId, TrelloAuthorization
 				TrelloConfiguration.Cache.Add(this);
 
 			_context.Merge(json);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 		}
 
 		/// <summary>
@@ -201,7 +201,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/CheckList.cs

@@ -15,7 +15,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a checklist.
 	/// </summary>
-	public class CheckList : ICheckList, IMergeJson<IJsonCheckList>, IBatchRefresh
+	public class CheckList : ICheckList, IMergeJson<IJsonCheckList>, IBatchRefresh, IHandleSynchronization
 	{
 		/// <summary>
 		/// Enumerates the data which can be pulled for check lists.
@@ -166,7 +166,7 @@ public CheckList(string id, TrelloAuthorization auth = null)
 		{
 			Id = id;
 			_context = new CheckListContext(id, auth);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 
 			_board = new Field<Board>(_context, nameof(Board));
 			_card = new Field<Card>(_context, nameof(Card));
@@ -233,7 +233,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/CustomField.cs

@@ -11,7 +11,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a custom field instance.
 	/// </summary>
-	public abstract class CustomField : ICustomField, IMergeJson<IJsonCustomField>
+	public abstract class CustomField : ICustomField, IMergeJson<IJsonCustomField>, IHandleSynchronization
 	{
 		private readonly Field<ICustomFieldDefinition> _definition;
 
@@ -49,7 +49,7 @@ internal CustomField(IJsonCustomField json, string cardId, TrelloAuthorization a
 				TrelloConfiguration.Cache.Add(this);
 
 			Context.Merge(json);
-			Context.Synchronized += Synchronized;
+			Context.Synchronized.Add(this);
 		}
 
 		/// <summary>
@@ -67,7 +67,7 @@ void IMergeJson<IJsonCustomField>.Merge(IJsonCustomField json, bool overwrite)
 			Context.Merge(json, overwrite);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = Context.Data.Id;
 			var handler = Updated;

Manatee.Trello/CustomFieldDefinition.cs

@@ -13,7 +13,7 @@ namespace Manatee.Trello
 	/// <summary>
 	/// Represents a custom field definition.
 	/// </summary>
-	public class CustomFieldDefinition : ICustomFieldDefinition, IMergeJson<IJsonCustomFieldDefinition>, IBatchRefresh
+	public class CustomFieldDefinition : ICustomFieldDefinition, IMergeJson<IJsonCustomFieldDefinition>, IBatchRefresh, IHandleSynchronization
 	{
 		private readonly Field<IBoard> _board;
 		private readonly Field<string> _fieldGroup;
@@ -98,7 +98,7 @@ internal CustomFieldDefinition(IJsonCustomFieldDefinition json, TrelloAuthorizat
 				TrelloConfiguration.Cache.Add(this);
 
 			_context.Merge(json);
-			_context.Synchronized += Synchronized;
+			_context.Synchronized.Add(this);
 		}
 
 		/// <summary>
@@ -225,7 +225,7 @@ void IBatchRefresh.Apply(string content)
 			_context.Merge(json);
 		}
 
-		private void Synchronized(IEnumerable<string> properties)
+		void IHandleSynchronization.HandleSynchronized(IEnumerable<string> properties)
 		{
 			Id = _context.Data.Id;
 			var handler = Updated;

Manatee.Trello/Internal/Synchronization/AttachmentContext.cs

@@ -99,7 +99,7 @@ public AttachmentContext(string id, string ownerId, TrelloAuthorization auth)
 			Data.Id = id;
 
 			Previews = new ReadOnlyAttachmentPreviewCollection(this, Auth);
-			Previews.Refreshed += (s, e) => OnMerged(new[] {nameof(Previews)});
+			Previews.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Previews)});
 		}
 
 		public static void UpdateParameters()

Manatee.Trello/Internal/Synchronization/BoardContext.cs

@@ -121,29 +121,30 @@ static BoardContext()
 					},
 				};
 		}
+
 		public BoardContext(string id, TrelloAuthorization auth)
 			: base(auth)
 		{
 			Data.Id = id;
 
 			Actions = new ReadOnlyActionCollection(typeof(Board), () => Data.Id, auth);
-			Actions.Refreshed += (s, e) => OnMerged(new[] {nameof(Actions) });
+			Actions.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Actions)});
 			Cards = new ReadOnlyCardCollection(typeof(Board), () => Data.Id, auth);
-			Cards.Refreshed += (s, e) => OnMerged(new[] {nameof(Cards) });
+			Cards.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Cards)});
 			CustomFields = new CustomFieldDefinitionCollection(() => Data.Id, auth);
-			CustomFields.Refreshed += (s, e) => OnMerged(new[] {nameof(CustomFields) });
+			CustomFields.Refreshed += (s, e) => OnMerged(new List<string> {nameof(CustomFields)});
 			Labels = new BoardLabelCollection(() => Data.Id, auth);
-			Labels.Refreshed += (s, e) => OnMerged(new[] {nameof(Labels) });
+			Labels.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Labels)});
 			Lists = new ListCollection(() => Data.Id, auth);
-			Lists.Refreshed += (s, e) => OnMerged(new[] {nameof(Lists) });
+			Lists.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Lists)});
 			Members = new ReadOnlyMemberCollection(EntityRequestType.Board_Read_Members, () => Data.Id, auth);
-			Members.Refreshed += (s, e) => OnMerged(new[] {nameof(Members) });
+			Members.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Members)});
 			Memberships = new BoardMembershipCollection(() => Data.Id, auth);
-			Memberships.Refreshed += (s, e) => OnMerged(new[] {nameof(Memberships) });
+			Memberships.Refreshed += (s, e) => OnMerged(new List<string> {nameof(Memberships)});
 			PowerUps = new PowerUpCollection(() => Data.Id, auth);
-			PowerUps.Refreshed += (s, e) => OnMerged(new[] {nameof(PowerUps) });
+			PowerUps.Refreshed += (s, e) => OnMerged(new List<string> {nameof(PowerUps)});
 			PowerUpData = new ReadOnlyPowerUpDataCollection(EntityRequestType.Board_Read_PowerUpData, () => Data.Id, auth);
-			PowerUpData.Refreshed += (s, e) => OnMerged(new[] { nameof(PowerUpData) });
+			PowerUpData.Refreshed += (s, e) => OnMerged(new List<string> {nameof(PowerUpData)});
 
 			BoardPreferencesContext = new BoardPreferencesContext(Auth);
 			BoardPreferencesContext.SubmitRequested += ct => HandleSubmitRequested("Preferences", ct);