Skip to content
This repository has been archived by the owner on Mar 1, 2020. It is now read-only.

Use **/* as default basePath instead of * #3

Merged
merged 2 commits into from
Apr 26, 2015
Merged

Use **/* as default basePath instead of * #3

merged 2 commits into from
Apr 26, 2015

Conversation

PeterDaveHello
Copy link
Contributor

No description provided.

@IonicaBizau
Copy link
Contributor

Thanks! However, What's the use-case? Can you please describe what will be the differences?

After this change, will be included everything from the directory?

@PeterDaveHello
Copy link
Contributor Author

If there is another directory in the basePath, we'll need it, ** can match the path including directories.

@IonicaBizau
Copy link
Contributor

@PeterDaveHello Cool! ✨ Please add yourself in the contributors array, in package.json.

@PeterDaveHello
Copy link
Contributor Author

Sure, done.

"contributors": [
{
"name": "Peter Dave Hello",
"email": "hsu <at> peterdavehello <dot> org",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be normalized on the next npm init.

@IonicaBizau IonicaBizau merged commit a760d86 into cdnjs:master Apr 26, 2015
@IonicaBizau
Copy link
Contributor

Thanks! 🚢 🎆

@PeterDaveHello PeterDaveHello deleted the patch-1 branch April 26, 2015 07:11
@IonicaBizau
Copy link
Contributor

@PeterDaveHello BTW, do you use this tool often? How do you feel using it? I'd be glad to improve it making the life easier. 😄

@PeterDaveHello
Copy link
Contributor Author

Personally I don't use it because I am very familiar with cdnjs's structure haha ... I sent this PR is because some others used it but I think the default config can be better 👍

@IonicaBizau
Copy link
Contributor

Haha, cool! The main reason I created it is because of the laggy git commands in cdnjs. 😄

@PeterDaveHello
Copy link
Contributor Author

BTW I think you can add it to https://github.com/cdnjs/cdnjs/wiki/Extensions%2C-Plugins%2C-Resources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants