Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fancybox documentation URL is incorrect #12212

Closed
abrahamguo opened this issue Nov 20, 2017 · 2 comments · Fixed by #12275
Closed

fancybox documentation URL is incorrect #12212

abrahamguo opened this issue Nov 20, 2017 · 2 comments · Fixed by #12275
Labels
🏷 Library Request A request to add a new library to cdnjs

Comments

@abrahamguo
Copy link

On the cdnjs page for fancybox, there is a link to http://fancyapps.com/fancybox/. This is the documentation for fancybox 2, but cdnjs references fancybox 3, the latest version. The documentation for fancybox 3 is located at http://fancyapps.com/fancybox/3.
@sufuf3
Copy link
Contributor

sufuf3 commented Nov 21, 2017

@abrahamguo Thanks
Need to update https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/fancybox/package.json#L6

@sufuf3 sufuf3 added the 🏷 Library Request A request to add a new library to cdnjs label Nov 21, 2017
@Billy4195
Copy link
Contributor

I'd like to finish this issue.

@Billy4195 Billy4195 mentioned this issue Nov 29, 2017
Merged
19 tasks
extend1994 pushed a commit to Billy4195/cdnjs that referenced this issue May 9, 2018
@Billy4195 @extend1994
Update fancybox homepage and license url field
5dea859 
Update the homepage and license fields in package.json, because the old
one is the homepage of fancybox 2. close cdnjs#12212.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷 Library Request A request to add a new library to cdnjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update fancybox homepage info in package.json Billy4195/cdnjs
3 participants
@abrahamguo @sufuf3 @Billy4195