[new] Add Infusion@2.0.0 w/ npm auto-update #10309
Conversation
There was a problem hiding this comment.
Could you please apply auto-update config in package.json? You can take a look at auto-update.md.
ajax/libs/infusion/package.json
Outdated
| "dependencies": { | ||
| "fluid-resolve": "1.2.0" | ||
| }, | ||
| "license": "(BSD-3-Clause OR ECL-2.0)", |
There was a problem hiding this comment.
Let's use licenses array as following:
"licenses": [
"BSD-3-Clause",
"ECL-2.0"
],Thanks
|
@pvnr0082t - by source files, do you mean the unminified consolidated files, or the individual source files for different parts of the framework that are available at https://github.com/fluid-project/infusion/tree/master/src? |
|
@waharnum I meant the former. Sorry for confusing you. |
|
@pvnr0082t minified CSS added - we don't currently minify JS/CSS for our /dist directory in NPM, but I will work on making that a part of our publish process to NPM for the next version. |
|
@waharnum Okay. Nice work! |
pvnr0082t
changed the title
|
@pvnr0082t thank you for speedy review - I'm excited to be able to put Infusion on cdnjs! |
|
Hello - checking in whether there is further work needed from our end to move this forward? I believe I've addressed all @pvnr0082t's comments. It would be great to have 2.0.0 release available on the CDN. |
|
ping @kennynaoh |
There was a problem hiding this comment.
Hi @waharnum, could you please also remove dependencies since we don't need it.
And please modify all files permission to -rw-r--r--.
Thanks!
|
Hi @maruilian11 - I've removed the Regarding file permissions, I don't see any files that have permissions other than |
|
@waharnum sorry, I think the permission is ok now. could you rebase this PR with our latest master branch by using |
|
@maruilian11 You should confirm that the contributor is using a GitHub gui or a local command line first before asking rebase ... btw, for non-active users without willing to clone the repo for just rebase, I think you should try to help rebase (rebase by you) even with a squash/fixup process. |
maruilian11
force-pushed
the
addInfusion
branch
from
8bdf875
to
8987104
Compare
|
@PeterDaveHello Got it. |
|
@maruilian11 your sentence looks strange ... |
|
LGTM |
|
@PeterDaveHello hmm... you mean the sentence I said to waharnum? |
|
@maruilian11 check it yourself ... |
|
@PeterDaveHello Just modify it. Could you help me check this PR? |
|
@maruilian11 I just don't get it, why don't you ask the contributor before the rebasing? I don't believe that is how the open source community works. |
|
@PeterDaveHello hmm... Because I think the PR only need to be rebased, I thought it would be helpful.... |
|
No problem on the rebase, thank you @maruilian11. Anything further needed on this one to make the PR acceptable? Thanks again! |
|
Looks like the most versions on npm package are not for production but development builds ... so should update
|
|
@PeterDaveHello - yes, the nature of our work means dev packages are published to NPM so that they can be sourced from other work. I was going to add a blanket I have an outstanding PR to generate minified Thank you for the merge! |
|
@waharnum no problem, thanks for your contribution. |
This PR adds the latest version of Infusion, a Javascript framework used by a number of international research teams working on accessible software projects and in a number of other educational contexts.
I'm one of the contributors and suggested adding it to cdnjs in this thread on our work mailing list: http://lists.idrc.ocad.ca/pipermail/fluid-work/2017-January/010222.html
Profile of the lib
Essential checklist
Git commit checklist