New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IndexedDBShim@2.2.1 w/ git auto-update #10443
Conversation
@x09326 Please review this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are other files?
https://github.com/axemclion/IndexedDBShim/tree/master/dist
ajax/libs/indexeddbshim/package.json
Outdated
"polyfill", | ||
"websql" | ||
], | ||
"license": "Apache-2.0 or MIT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you're doing internally, but an array is not preferred anymore for package.json
: https://docs.npmjs.com/files/package.json#license
Some old packages used license objects or a "licenses" property containing an array of license objects:
Those styles are now deprecated. Instead, use SPDX expressions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other files are in master branch, not in the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maruilian11 I have modified the part of license. Please review it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @brettz9, we use SPDX expressions, too. Just keep the same structure when we meet multi-license lib in cdnjs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we've since added parentheses for the license field as per the SPDX specs (on 1/27: )...
Please don't mention |
LGTM |
@x09326 @kennynaoh Please help me make the double check, thanks! |
@lcd78706 |
@x09326 I have rebased it to the latest master branch. Please review it again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use its repo name IndexedDBShim
as the easier to be understood name, any reason you need to change it to indexeddbshim
?
@PeterDaveHello |
@lcd78706 We don't decide the library name by a single factor, repository name, readability should also be considered, let's update it. |
@x09326 |
LGTM |
close #10261, cc @brettz9
Pull request for issue: #10261
Related issue(s): # #
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
https://github.com/axemclion/IndexedDBShim/blob/master/LICENSE-MIT
Essential checklist
Auto-update checklist
Git commit checklist