Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap-waitingfor@1.2.4 w/ git auto-update #10496

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

hare1039
Copy link
Contributor

@hare1039 hare1039 commented Feb 1, 2017

Pull request for issue: #10403
Related issue(s): # #

@cdnjs/intern3 Please help me reviewing this PR. Thank you.
Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

  • Git repository (required): https://github.com/ehpc/bootstrap-waitingfor
  • Official website (optional, not the repository): bootsnipp.com/snippets/featured/quotwaiting-forquot-modal-dialog
  • NPM package url (optional):
  • License and its reference: MIT, ref
  • GitHub / Bitbucket popularity (required):
    • Count of watchers: 8
    • Count of stars: 97
    • Count of forks: 65
  • NPM download stats (optional):
    • Downloads in the last day:
    • Downloads in the last week:
    • Downloads in the last month:

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

Copy link
Contributor

@clairetsai818 clairetsai818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10403 is a duplicate issue

@PeterDaveHello
Copy link
Contributor

PeterDaveHello commented Feb 1, 2017

I think we've discussed about the new conventions about sending new a pull request in private message, there are some earlier works you'll need to do before sending new pull requests.
So I just closed this PR, you can reopen this when you finished the pre-requirement works.

@hare1039
Copy link
Contributor Author

hare1039 commented Feb 2, 2017

@pvnr0082t Please help me reviewing this PR. Thank you.

"description": "Waiting for dialog with progress bar for Bootstrap",
"repository": {
"type": "git",
"url": "git+https://github.com/ehpc/bootstrap-waitingfor.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterDaveHello Is it better to use git:// instead of git+https://?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both fine

Copy link
Contributor

@pvnr0082t pvnr0082t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterDaveHello PeterDaveHello merged commit 9e908bc into cdnjs:master Feb 2, 2017
@hare1039 hare1039 deleted the bootstrap-waitingfor branch February 2, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants