-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap-waitingfor@1.2.4 w/ git auto-update #10496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#10403 is a duplicate issue
I think we've discussed about the new conventions about sending new a pull request in private message, there are some earlier works you'll need to do before sending new pull requests. |
No worry about #10403 this time.
@pvnr0082t Please help me reviewing this PR. Thank you. |
"description": "Waiting for dialog with progress bar for Bootstrap", | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/ehpc/bootstrap-waitingfor.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterDaveHello Is it better to use git://
instead of git+https://
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request for issue: #10403
Related issue(s): # #
@cdnjs/intern3 Please help me reviewing this PR. Thank you.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist