Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update auto-update config of inferno #10887

Merged
merged 1 commit into from
Mar 28, 2017
Merged

update auto-update config of inferno #10887

merged 1 commit into from
Mar 28, 2017

Conversation

pvnr0082t
Copy link
Contributor

update auto-update config to exclude *.ts files

Pull request for issue: #10886
@cdnjs/intern2 Please help me review this pull request, thank you.

Profile of the lib

PeterBot
PeterBot approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@PeterBot PeterBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvnr0082t congratulations! 3feda8a CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/5473, thank you 😀

@PeterDaveHello
Copy link
Contributor

What about index.js?

@PeterDaveHello
Copy link
Contributor

@pvnr0082t would you please also confirm that if we need other js files? thanks

@pvnr0082t pvnr0082t changed the title update auto-update config of inferno, close #10886 update auto-update config of inferno Mar 22, 2017
@pvnr0082t pvnr0082t mentioned this pull request Mar 22, 2017
Closed
@PeterDaveHello
Copy link
Contributor

Any updates?

@pvnr0082t
update auto-update config of inferno, close cdnjs#10886
f45d964 
update auto-update config to exclude *.ts files
PeterBot
PeterBot approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@PeterBot PeterBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvnr0082t congratulations! f45d964 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/5756, thank you 😀

@pvnr0082t
Copy link
Contributor Author

After discussed in infernojs/inferno#958, we only need inferno.js and inferno.min.js. I have modified the auto-update config. @cdnjs/intern2 @maruilian11 Please help me review this PR, thank you.

@PeterDaveHello PeterDaveHello merged commit 36f8b0c into cdnjs:master Mar 28, 2017
@pvnr0082t pvnr0082t deleted the update-inferno branch March 28, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterBot PeterBot PeterBot approved these changes

@kennynaoh kennynaoh Awaiting requested review from kennynaoh

@x09326 x09326 Awaiting requested review from x09326

@maruilian11 maruilian11 Awaiting requested review from maruilian11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvnr0082t @PeterDaveHello @PeterBot