[Author] Add bulmaswatch w/ git auto-update via single package.json #11339

jenil · 2017-05-28T19:41:09Z

Pull request for issue: #10823
Related issue(s): #11322

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/jenil/bulmaswatch
Official website (optional, not the repository):
NPM package url (optional):
License and its reference:
GitHub / Bitbucket popularity (required):
- Count of watchers: 6
- Count of stars: 107
- Count of forks: 6
NPM download stats (optional):
- Downloads in the last day:
- Downloads in the last week:
- Downloads in the last month:

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

Oops 😨 27969f9 CI test failed ❗

@jenil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/8567 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@jenil congratulations! 6bddb78 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/8568, thank you 😀

sufuf3

Nice work.
May I ask you how do you send this pull request? via GitHub website or use git command?
I think the commit should squash to one commit, if you use git command, we can help you how to do this.
But if you use GitHub website, it can't squash the commit.

If you want to try to use git command but worried cdnjs's repo is too huge. You could use sparseCheckout, it lets you check out only the files you want. Here is the tutorial: https://github.com/cdnjs/cdnjs/blob/master/documents/sparseCheckout.md

BTY, Would you change the commit message to the followings?

Add bulmaswatch w/ git auto-update via single package.json

close #10823

This will helpful to us to check the git log, and when this PR close, it will close the related issue.

Thank you for your contribution.

sufuf3 · 2017-05-29T07:00:17Z

ajax/libs/bulmaswatch/package.json

+  "autoupdate": {
+    "source": "git",
+    "target": "git://github.com/jenil/bulmaswatch.git",
+    "fileMap": [{


Let's let { move to next line.
Make same format as others.

sufuf3 · 2017-05-29T07:01:20Z

ajax/libs/bulmaswatch/package.json

+      "files": [
+        "bulmaswatch*.+(js|css|map)"
+      ]
+    }]


Let's let ] move to next line.
Make same format as others.
the fileMap part as the followings:

"fileMap": [ { "basePath": "", "files": [ "bulmaswatch*.+(js|css|map)" ] } ]

jenil · 2017-05-29T09:45:13Z

Hey @sufuf3!

I sent the PR using the Github website.
I tried using the git command but gave up since the repo was too huge. Even using the sparseChecout the repo is reasonably huge (2 gigs+), is there any other way to do this?

sufuf3 · 2017-05-30T15:08:32Z

No.
But we can help you to squash the commit after the package.json is fine. 😄

PeterBot

Oops 😨 3c868e5 CI test failed ❗

@jenil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/8618 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterDaveHello · 2017-05-30T18:32:54Z

@hare1039 help squash and correct commit message please.

PeterBot

@jenil congratulations! f6ff703 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/8624, thank you 😀

hare1039 · 2017-05-30T19:07:31Z

ajax/libs/bulmaswatch/package.json

+    "themes"
+  ],
+  "autoupdate": 
+  {


The position of this '{' is a little bit not in our format, but the review bot didn't catch it , so I think its fine.

hare1039 · 2017-05-30T19:18:00Z

ajax/libs/bulmaswatch/package.json

+      {
+        "basePath": "",
+        "files": [
+          "bulmaswatch*.+(js|css|map)"


I can't use this rule to fetch files from GitHub.
The file structure is [theme_name]/bulmaswatch.min.css and
[theme_name]/bulmaswatch.min.css.map

I'm not sure what rules should we apply here.
@pvnr0082t Please give some advices on this PR. Should we list all theme_names ?

@hare1039 I forgot the basePath should be default
@jenil could you modified the auto-update part as the followings? I'm sorry that I not notice the basePath should be basePath to get the files.

"autoupdate": { "source": "git", "target": "git://github.com/jenil/bulmaswatch.git", "fileMap": [ { "basePath": "default", "files": [ "bulmaswatch*.+(js|css|map)" ] } ] }

@sufuf3 We only need default ?

@hare1039 I think we can let author @jenil decide this.
But at first time, the author write the default/bulmaswatch.min.css as the main file(filename), so I think just need default as basePath.
ref: 6b13062

@sufuf3 @hare1039 I think we can't have default in the basePath since each theme has its own bulmaswatch.min.css. I had set the filename assuming that it is just a default file that I need to refer.

@jenil then let's use the auto-update as the followings, this will get all the theme's files:

"autoupdate": { "source": "git", "target": "git://github.com/jenil/bulmaswatch.git", "fileMap": [ { "basePath": "", "files": [ "*/bulmaswatch*.+(js|css|map)" ] } ] }

And the "filename": "bulmaswatch.min.css", change to "filename": "default/bulmaswatch.min.css", let it as the main file.
Thank you.

@jenil then let's use the auto-update as the followings, this will get all the theme's files:

"autoupdate": { "source": "git", "target": "git://github.com/jenil/bulmaswatch.git", "fileMap": [ { "basePath": "", "files": [ "*/bulmaswatch*.+(js|css|map)" ] } ] }

And Let's change "filename": "bulmaswatch.min.css", to "filename": "default/bulmaswatch.min.css",

PeterDaveHello · 2017-06-01T19:37:37Z

@jenil any updates here or need help? Thanks.

PeterBot

Oops 😨 6a144e4 CI test failed ❗

@jenil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/8703 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterDaveHello · 2017-06-01T19:50:04Z

Oops, branch is too old, I'll fix it.

close #10823

PeterBot

@jenil congratulations! 086c605 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/8706, thank you 😀

dakshshah96

LGTM. 💯

sufuf3

LGTM 👍

sufuf3 · 2017-06-02T15:40:41Z

@hare1039 @cdnjs/library-reviewer please help review this PR, thanks.

hare1039

LGTM

PeterDaveHello · 2017-06-03T07:42:13Z

@jenil 👍

PeterBot requested review from sufuf3, maruilian11, extend1994 and pvnr0082t May 28, 2017 19:41

PeterBot suggested changes May 28, 2017

View reviewed changes

PeterBot approved these changes May 28, 2017

View reviewed changes

sufuf3 suggested changes May 29, 2017

View reviewed changes

PeterBot suggested changes May 30, 2017

View reviewed changes

PeterDaveHello requested a review from hare1039 May 30, 2017 18:32

PeterDaveHello assigned hare1039 May 30, 2017

PeterBot approved these changes May 30, 2017

View reviewed changes

hare1039 reviewed May 30, 2017

View reviewed changes

hare1039 suggested changes May 30, 2017

View reviewed changes

sufuf3 changed the title ~~Add bulmaswatch [new]~~ [Author] Add bulmaswatch w/ git auto-update via single package.json May 31, 2017

jenil mentioned this pull request May 31, 2017

Add to cdnjs jenil/bulmaswatch#1

Closed

PeterBot suggested changes Jun 1, 2017

View reviewed changes

PeterDaveHello requested review from yahsieh, dakshshah96, sufuf3 and hare1039 June 1, 2017 19:50

Add bulmaswatch w/ git auto-update via single package.json

086c605

close #10823

PeterBot approved these changes Jun 1, 2017

View reviewed changes

dakshshah96 approved these changes Jun 2, 2017

View reviewed changes

sufuf3 approved these changes Jun 2, 2017

View reviewed changes

hare1039 approved these changes Jun 2, 2017

View reviewed changes

PeterDaveHello merged commit d564b4f into cdnjs:master Jun 3, 2017

PeterDaveHello added a commit that referenced this pull request Jun 3, 2017

Import bulmaswatch from git repo, cc #11339

d4469c3

jenil deleted the bulmaswat branch June 5, 2017 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Author] Add bulmaswatch w/ git auto-update via single package.json #11339

[Author] Add bulmaswatch w/ git auto-update via single package.json #11339

jenil commented May 28, 2017 •

edited

PeterBot left a comment

PeterBot left a comment

sufuf3 left a comment

sufuf3 May 29, 2017

sufuf3 May 29, 2017

jenil commented May 29, 2017

sufuf3 commented May 30, 2017

PeterBot left a comment

PeterDaveHello commented May 30, 2017

PeterBot left a comment

hare1039 May 30, 2017

hare1039 May 30, 2017

sufuf3 May 31, 2017 •

edited

hare1039 May 31, 2017

sufuf3 May 31, 2017 •

edited

jenil May 31, 2017

sufuf3 May 31, 2017

sufuf3 May 31, 2017 •

edited

PeterDaveHello commented Jun 1, 2017

PeterBot left a comment

PeterDaveHello commented Jun 1, 2017

PeterBot left a comment

dakshshah96 left a comment

sufuf3 left a comment

sufuf3 commented Jun 2, 2017

hare1039 left a comment

PeterDaveHello commented Jun 3, 2017

[Author] Add bulmaswatch w/ git auto-update via single package.json #11339

[Author] Add bulmaswatch w/ git auto-update via single package.json #11339

Conversation

jenil commented May 28, 2017 • edited

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 May 29, 2017

Choose a reason for hiding this comment

sufuf3 May 29, 2017

Choose a reason for hiding this comment

jenil commented May 29, 2017

sufuf3 commented May 30, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented May 30, 2017

PeterBot left a comment

Choose a reason for hiding this comment

hare1039 May 30, 2017

Choose a reason for hiding this comment

hare1039 May 30, 2017

Choose a reason for hiding this comment

sufuf3 May 31, 2017 • edited

Choose a reason for hiding this comment

hare1039 May 31, 2017

Choose a reason for hiding this comment

sufuf3 May 31, 2017 • edited

Choose a reason for hiding this comment

jenil May 31, 2017

Choose a reason for hiding this comment

sufuf3 May 31, 2017

Choose a reason for hiding this comment

sufuf3 May 31, 2017 • edited

Choose a reason for hiding this comment

PeterDaveHello commented Jun 1, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Jun 1, 2017

PeterBot left a comment

Choose a reason for hiding this comment

dakshshah96 left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 commented Jun 2, 2017

hare1039 left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Jun 3, 2017

jenil commented May 28, 2017 •

edited

sufuf3 May 31, 2017 •

edited

sufuf3 May 31, 2017 •

edited

sufuf3 May 31, 2017 •

edited