[author][new] Add billboard.js w/ npm auto-update via single package.json #11413

netil · 2017-06-16T06:16:45Z

Pull request for issue: #11409
Related issue(s):

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/naver/billboard.js
Official website (optional, not the repository): https://naver.github.io/billboard.js/
NPM package url (optional): https://www.npmjs.com/package/billboard.js
License and its reference: MIT, https://github.com/naver/billboard.js/blob/master/LICENSE
GitHub / Bitbucket popularity (required):
- Count of watchers: 31
- Count of stars: 908
- Count of forks: 1,151
NPM download stats (optional):
- Downloads in the last day:
- Downloads in the last week:
- Downloads in the last month:

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

Oops 😨 8794481 CI test failed ❗

@netil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/9197 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@netil congratulations! 90091b7 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9198, thank you 😀

dakshshah96

Please make the requested changes.

Also, if you're working locally and not directly from the GitHub interface, make the following changes:

Squash your commits into a single commit
Use the following commit message:

Add billboard.js w/ npm auto-update via single package.json

close #11049

If you're not working locally, don't worry about these. Our maintainers will help you with it.

dakshshah96 · 2017-06-16T08:52:40Z

ajax/libs/billboard.js/package.json

+  "description": "Re-usable easy interface JavaScript chart library, based on D3 v4+",
+  "author": "NAVER Corp.",
+  "filename": "billboard.min.js",
+  "homepage": "http://naver.github.io/billboard.js/",


Please use https here.

dakshshah96 · 2017-06-16T08:54:17Z

ajax/libs/billboard.js/package.json

+    {
+      "basePath": "dist",
+      "files": [
+        "**/!(*.+(map))"


I don't think we need to exclude the map files. Seems fine to use **/* inside dist.

netil · 2017-06-16T09:53:02Z

@dakshshah96 thanks. I did requested changes (sorry not squashing, I did changes directly from web)

PeterBot

@netil congratulations! 3846562 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9203, thank you 😀

sufuf3

LGTM
Just need to squash to one commit.
Would you want to try squash to one commit by yourself?

If you want to try to use git command but worried cdnjs's repo is too huge. You could use sparseCheckout, it lets you check out only the files you want. Here is the tutorial: https://github.com/cdnjs/cdnjs/blob/master/documents/sparseCheckout.md

OR, I can help you squash to one commit.

Thank you for your contribution.

netil · 2017-06-19T09:52:23Z

@sufuf3, would you mind to squash?

PeterBot

Oops 😨 49d78ba CI test failed ❗

@netil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/9277 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 a0cac9c CI test failed ❗

@netil please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/9279 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@netil congratulations! 8f64e56 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9288, thank you 😀

close #11409

PeterBot

@netil congratulations! 351e452 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9289, thank you 😀

sufuf3 · 2017-06-19T13:15:03Z

@netil Done 😄
Help squash, rebase to master, modified line 26 from ] to ] (delete two space which in the end of this line).

sufuf3

LGTM

sufuf3 · 2017-06-20T17:01:26Z

@cdnjs/intern3 @dakshshah96
Please help review this PR, Thank you.

yahsieh

LGTM

sufuf3 · 2017-06-21T10:50:05Z

@cdnjs/library-reviewer
Please help review this PR, Thank you.

dakshshah96

LGTM

PeterBot requested review from yahsieh, dakshshah96, sufuf3 and hare1039 June 16, 2017 06:16

PeterBot suggested changes Jun 16, 2017

View reviewed changes

PeterBot approved these changes Jun 16, 2017

View reviewed changes

dakshshah96 suggested changes Jun 16, 2017

View reviewed changes

dakshshah96 changed the title ~~[author][new] Add billboard.js@1.0.0 w/ npm auto-update~~ [author][new] Add billboard.js w/ npm auto-update via single package.json Jun 16, 2017

PeterBot approved these changes Jun 16, 2017

View reviewed changes

sufuf3 reviewed Jun 17, 2017

View reviewed changes

PeterBot suggested changes Jun 19, 2017

View reviewed changes

PeterBot approved these changes Jun 19, 2017

View reviewed changes

Add billboard.js w/ npm auto-update via single package.json

351e452

close #11409

PeterBot approved these changes Jun 19, 2017

View reviewed changes

sufuf3 requested review from dakshshah96 and sufuf3 June 19, 2017 13:15

sufuf3 approved these changes Jun 19, 2017

View reviewed changes

netil mentioned this pull request Jun 20, 2017

CDN support naver/billboard.js#6

Closed

yahsieh approved these changes Jun 20, 2017

View reviewed changes

sufuf3 requested review from maruilian11, extend1994 and pvnr0082t June 20, 2017 17:14

dakshshah96 approved these changes Jun 21, 2017

View reviewed changes

extend1994 approved these changes Jun 21, 2017

View reviewed changes

sufuf3 requested a review from PeterDaveHello June 21, 2017 23:00

PeterDaveHello merged commit b6a5d04 into cdnjs:master Jun 22, 2017

PeterDaveHello added a commit that referenced this pull request Jun 22, 2017

Import billboard.js from npm, cc #11413

992ce27

netil mentioned this pull request Jan 15, 2020

billboard.js is not updating #13661

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[author][new] Add billboard.js w/ npm auto-update via single package.json #11413

[author][new] Add billboard.js w/ npm auto-update via single package.json #11413

netil commented Jun 16, 2017

PeterBot left a comment

PeterBot left a comment

dakshshah96 left a comment

dakshshah96 Jun 16, 2017

dakshshah96 Jun 16, 2017

netil commented Jun 16, 2017

PeterBot left a comment

sufuf3 left a comment

netil commented Jun 19, 2017

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

sufuf3 commented Jun 19, 2017

sufuf3 left a comment

sufuf3 commented Jun 20, 2017

yahsieh left a comment

sufuf3 commented Jun 21, 2017

dakshshah96 left a comment

[author][new] Add billboard.js w/ npm auto-update via single package.json #11413

[author][new] Add billboard.js w/ npm auto-update via single package.json #11413

Conversation

netil commented Jun 16, 2017

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

dakshshah96 left a comment

Choose a reason for hiding this comment

dakshshah96 Jun 16, 2017

Choose a reason for hiding this comment

dakshshah96 Jun 16, 2017

Choose a reason for hiding this comment

netil commented Jun 16, 2017

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

netil commented Jun 19, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 commented Jun 19, 2017

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 commented Jun 20, 2017

yahsieh left a comment

Choose a reason for hiding this comment

sufuf3 commented Jun 21, 2017

dakshshah96 left a comment

Choose a reason for hiding this comment