Add i18next-xhr-backend@1.4.2 w/ npm auto-update #11447

dakshshah96 · 2017-06-24T10:31:29Z

Pull request for issue: #10720
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/i18next/i18next-xhr-backend
Official website (optional, not the repository):
NPM package url (optional): https://www.npmjs.com/package/i18next-xhr-backend
License and its reference: MIT
GitHub / Bitbucket popularity (required):
- Count of watchers: 2
- Count of stars: 47
- Count of forks: 40
NPM download stats (optional):
- Downloads in the last day: 2,191
- Downloads in the last week: 13,805
- Downloads in the last month: 57,005

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

@dakshshah96 congratulations! 0b2407d CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9487, thank you 😀

sufuf3

I think this PR is fine. Just need to tag the author to notice him. Could you add cc @jamuhl in the commit message?

Although there are more versions from GitHub then npm.
But I think it's OK because the git tag v0.3.0 is duplicate with 0.3.0.
If manually add v0.0.2 from GitHub is better.
(npm release v0.0.1, but GitHub repo didn't release this version)

dakshshah96 · 2017-06-25T09:15:57Z

@sufuf3 Can you please clarify that? I didn't get what you meant about the manual additions.

sufuf3 · 2017-06-25T09:25:54Z

@dakshshah96 Sorry about that.

Could you cc @jamuhl in the commit message to notice author?
Could you manually add v0.0.2 from GitHub in another commit? Let CDNJS host v0.0.2 because npm auto-update can't get this version.

Thank you.

PeterBot

@dakshshah96 congratulations! fcc555d CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9526, thank you 😀

PeterBot

@dakshshah96 congratulations! ef1859f CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9527, thank you 😀

PeterBot

@dakshshah96 congratulations! d6d2a8d CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9529, thank you 😀

PeterBot

@dakshshah96 congratulations! 949dcb0 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9528, thank you 😀

dakshshah96 · 2017-06-25T09:50:04Z

@sufuf3 Done 👍

sufuf3

LGTM

sufuf3

@dakshshah96
I'm sorry. I found that the versions before v0.0.4 should manually add due to the different file structure.
Would you add them?
Thank you.

Sorry. I didn't notice that.

extend1994

I don't think that the author packaged the versions before v0.0.4, which means that the users can't use these versions directly, but have to use some commands to get the correct files, e.g gulp build (source: https://github.com/i18next/i18next-xhr-backend/tree/0.0.3#i18next-xhr-backend).
In a conclusion, we don't need to manually add them. If we need, I think we should ask the author can he/she provide the files.

PeterBot

@dakshshah96 congratulations! 67f6b29 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12493, thank you 😀

sufuf3

As @extend1994 mention #11447 (review)
Then this PR LGTM

Thanks.

extend1994

@sufuf3 Please remove your manual adding of v0.0.2, thanks.
Another reference: similar library i18next-browser-languagedetector.
You can see the same situation in v0.0.10 ~ v0.0.5. They are not hosted by CDNJS.

@jamuhl

close cdnjs#10720, cc @jamuhl

PeterBot

@dakshshah96 congratulations! 0f9205e CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12531, thank you 😀

sufuf3 · 2017-09-12T12:25:56Z

@extend1994 I removed it, please help review this PR, thanks.

extend1994

LGTM

PeterDaveHello · 2017-09-14T06:30:17Z

Thanks all!

PeterBot requested review from sufuf3, extend1994 and hare1039 June 24, 2017 10:31

PeterDaveHello added the in progress label Jun 24, 2017

PeterBot approved these changes Jun 24, 2017

View reviewed changes

sufuf3 reviewed Jun 25, 2017

View reviewed changes

dakshshah96 force-pushed the add/i18next-xhr-backend branch from 0b2407d to fcc555d Compare June 25, 2017 09:35

PeterBot approved these changes Jun 25, 2017

View reviewed changes

dakshshah96 force-pushed the add/i18next-xhr-backend branch from ef1859f to 949dcb0 Compare June 25, 2017 09:44

PeterBot approved these changes Jun 25, 2017

View reviewed changes

dakshshah96 force-pushed the add/i18next-xhr-backend branch from 949dcb0 to d6d2a8d Compare June 25, 2017 09:46

PeterBot approved these changes Jun 25, 2017

View reviewed changes

sufuf3 self-requested a review June 25, 2017 14:24

sufuf3 approved these changes Jun 25, 2017

View reviewed changes

sufuf3 reviewed Jun 25, 2017

View reviewed changes

sufuf3 self-requested a review June 25, 2017 14:33

extend1994 suggested changes Jul 1, 2017

View reviewed changes

sufuf3 requested a review from extend1994 September 11, 2017 12:41

sufuf3 force-pushed the add/i18next-xhr-backend branch from d6d2a8d to 67f6b29 Compare September 11, 2017 12:58

ghost assigned sufuf3 Sep 11, 2017

PeterBot approved these changes Sep 11, 2017

View reviewed changes

sufuf3 approved these changes Sep 11, 2017

View reviewed changes

extend1994 suggested changes Sep 12, 2017

View reviewed changes

Add i18next-xhr-backend@1.4.2 w/ npm auto-update

0f9205e

close cdnjs#10720, cc @jamuhl

sufuf3 force-pushed the add/i18next-xhr-backend branch from 67f6b29 to 0f9205e Compare September 12, 2017 12:22

PeterBot approved these changes Sep 12, 2017

View reviewed changes

sufuf3 requested review from extend1994 and mercyg September 12, 2017 12:26

extend1994 approved these changes Sep 13, 2017

View reviewed changes

extend1994 requested a review from PeterDaveHello September 13, 2017 03:49

PeterDaveHello merged commit bf2e689 into cdnjs:master Sep 14, 2017

ghost removed the in progress label Sep 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add i18next-xhr-backend@1.4.2 w/ npm auto-update #11447

Add i18next-xhr-backend@1.4.2 w/ npm auto-update #11447

dakshshah96 commented Jun 24, 2017

PeterBot left a comment

sufuf3 left a comment

dakshshah96 commented Jun 25, 2017

sufuf3 commented Jun 25, 2017

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

dakshshah96 commented Jun 25, 2017

sufuf3 left a comment

sufuf3 left a comment

extend1994 left a comment

PeterBot left a comment

sufuf3 left a comment

extend1994 left a comment •

edited

Loading

PeterBot left a comment

sufuf3 commented Sep 12, 2017

extend1994 left a comment

PeterDaveHello commented Sep 14, 2017

Add i18next-xhr-backend@1.4.2 w/ npm auto-update #11447

Add i18next-xhr-backend@1.4.2 w/ npm auto-update #11447

Conversation

dakshshah96 commented Jun 24, 2017

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

dakshshah96 commented Jun 25, 2017

sufuf3 commented Jun 25, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

dakshshah96 commented Jun 25, 2017

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

extend1994 left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

extend1994 left a comment • edited Loading

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 commented Sep 12, 2017

extend1994 left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Sep 14, 2017

extend1994 left a comment •

edited

Loading