Add snarkdown w/ npm auto-update via single package.json #11830

pyvkd · 2017-09-13T11:57:35Z

Profile of the lib

Git repository (required): https://github.com/developit/snarkdown
Official website (optional, not the repository):
NPM package url (optional): https://www.npmjs.com/package/snarkdown
License and its reference: MIT
GitHub / Bitbucket popularity (required):
- Count of watchers: 16
- Count of stars: 610
- Count of forks: 36
NPM download stats (optional):
- Downloads in the last day: 62
- Downloads in the last week: 219
- Downloads in the last month: 866

PeterBot

Oops 😨 d2681e0 CI test failed ❗

@pyvkd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/12583 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 57c5e83 CI test failed ❗

@pyvkd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/12592 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 30fc132 CI test failed ❗

@pyvkd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/12612 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@pyvkd congratulations! 49823de CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12617, thank you 😀

sufuf3

@pyvkd Thank you for your contribution.
I think this PR is good, except some parts.

May I ask you how do you send this pull request? via GitHub website or use git command?
I think the commit should squash to one commit, if you use git command, we can help you how to do this.
But if you use GitHub website, it can't squash the commit. I can help you squash to one commit.

BTW, the commit message needs to be as the followings:

Add snarkdown w/ npm auto-update via single package.json

close #11827, cc developit

Thank you.

Memo: the file of v0.5.0~v1.0.0 I found there is no files can use in web front-end, so it does not matter.

sufuf3 · 2017-09-14T15:13:20Z

ajax/libs/snarkdown/package.json

+  "description": "Transform Markdown into HTML.",
+  "authors": [
+    "Jason Miller <jason@developit.ca>"
+  ],


Let's modify from A to B. Because there is one author not authors.

A

"authors": [ "Jason Miller <jason@developit.ca>" ],

B

"author": "Jason Miller <jason@developit.ca>",

Thank you.

sufuf3 · 2017-09-14T15:16:09Z

ajax/libs/snarkdown/package.json

+    "html",
+    "parser"
+  ],
+  "filename": "snarkdown.min.js",


Let's move "filename": "snarkdown.min.js", between name and description field.
Because we'd like let people know what file they need it in the first glance.
Thank you.

sufuf3 · 2017-09-14T15:24:37Z

@pyvkd I have a question.
Could we use snarkdown.es.js this file in web front-end?
like <script src="xxxx.js"></script>

If we can't use it in web front-end, we need to change the auto-update config.
Thank you.

PeterDaveHello · 2017-09-15T08:12:51Z

@sufuf3 take a look:

https://philipwalton.com/articles/deploying-es2015-code-in-production-today/

<!-- Browsers with ES module support load this file. -->
<script type="module" src="main.js"></script>

<!-- Older browsers load this file (and module-supporting -->
<!-- browsers know *not* to load this file). -->
<script nomodule src="main-legacy.js"></script>

It may need some more attribute, but anyway, it should be minified.

sufuf3 · 2017-09-15T08:54:01Z

Got it, thank you.

pyvkd · 2017-09-15T11:16:00Z

@sufuf3 i used github.com. I can use git command line as well.

PeterDaveHello · 2017-09-15T11:18:06Z

@pyvkd I think the most easiey way here is to keep using GitHub GUI, just fix the issues and we can squash the commits here for you.

PeterBot

Oops 😨 5e2fa6f CI test failed ❗

@pyvkd please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/12705 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterDaveHello · 2017-09-16T13:12:18Z

I'll squash and rebase the branch now.

PeterBot

@pyvkd congratulations! ef9d44e CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12709, thank you 😀

PeterDaveHello · 2017-09-17T08:22:46Z

Ping @cdnjs/intern3

PeterBot

@pyvkd congratulations! 223f9f9 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12862, thank you 😀

sufuf3

Sorry for the late review.
Helped modify the commit message.
LGTM

sufuf3 · 2017-09-21T00:16:41Z

@cdnjs/active-contributor @cdnjs/intern3
Please help review this PR, Thank you.

PeterBot

@pyvkd congratulations! f74149b CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/12933, thank you 😀

extend1994

LGTM

PeterDaveHello

@sufuf3 @extend1994 so the snarkdown.es.js was verified working for browser but not for nodejs only?

PeterBot · 2018-04-19T20:01:15Z

Any updates here? Please let me know if you need any help. Thanks!

(This is an automatic ping message, sorry for disturbing, we will get back here ASAP.)

cc @sashberd

sufuf3 · 2018-04-23T01:05:22Z

As the mention developit/snarkdown#39 (comment) & #11830 (comment)
Maybe it's can be used in web front-end.

@PeterDaveHello would you please take a look?
Thank you very much.

PeterDaveHello

Please note that the filename needs no .min as it's minified.

@developit

close cdnjs#11827, cc @developit

PeterBot

@pyvkd congratulations! 868fa02 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/20300, thank you 😀

PeterDaveHello · 2018-05-05T10:14:51Z

@sufuf3 @extend1994 please take a look at my "approval" review, just a small issue and I fixed here.

PeterBot requested review from dakshshah96, extend1994, hare1039, mercyg and sufuf3 September 13, 2017 11:57

pyvkd mentioned this pull request Sep 13, 2017

[Request] Add snarkdown #11827

Closed

PeterBot suggested changes Sep 13, 2017

View reviewed changes

pyvkd changed the title ~~Adding snarkdown~~ Add snarkdown w/ npm auto-update Sep 13, 2017

PeterBot suggested changes Sep 14, 2017

View reviewed changes

PeterBot approved these changes Sep 14, 2017

View reviewed changes

sufuf3 suggested changes Sep 14, 2017

View reviewed changes

sufuf3 changed the title ~~Add snarkdown w/ npm auto-update~~ Add snarkdown w/ npm auto-update via single package.json Sep 14, 2017

PeterBot suggested changes Sep 16, 2017

View reviewed changes

PeterDaveHello requested review from yahsieh and sufuf3 September 16, 2017 13:11

PeterDaveHello force-pushed the snarkdown branch from 5e2fa6f to ef9d44e Compare September 16, 2017 13:16

ghost assigned PeterDaveHello Sep 16, 2017

ghost added the in progress label Sep 16, 2017

PeterBot approved these changes Sep 16, 2017

View reviewed changes

sufuf3 force-pushed the snarkdown branch from ef9d44e to 223f9f9 Compare September 21, 2017 00:10

ghost assigned sufuf3 Sep 21, 2017

PeterBot approved these changes Sep 21, 2017

View reviewed changes

sufuf3 approved these changes Sep 21, 2017

View reviewed changes

PeterDaveHello requested a review from maruilian11 September 22, 2017 19:26

extend1994 force-pushed the snarkdown branch from 223f9f9 to f74149b Compare September 23, 2017 08:59

ghost assigned extend1994 Sep 23, 2017

PeterBot approved these changes Sep 23, 2017

View reviewed changes

extend1994 approved these changes Sep 23, 2017

View reviewed changes

extend1994 requested a review from PeterDaveHello September 23, 2017 09:04

PeterDaveHello reviewed Sep 25, 2017

View reviewed changes

sufuf3 mentioned this pull request Dec 14, 2017

Is snarkdown.es.js can be work in browser? developit/snarkdown#39

Closed

sufuf3 added the 🔄 Wait for response label Feb 9, 2018

sufuf3 removed the 🔄 Wait for response label Apr 23, 2018

sufuf3 requested review from PeterDaveHello and removed request for maruilian11 April 23, 2018 01:05

PeterDaveHello approved these changes May 5, 2018

View reviewed changes

Add snarkdown w/ npm auto-update via single package.json

868fa02

close cdnjs#11827, cc @developit

PeterDaveHello force-pushed the snarkdown branch from f74149b to 868fa02 Compare May 5, 2018 10:01

PeterBot approved these changes May 5, 2018

View reviewed changes

PeterDaveHello merged commit 6f7e30b into cdnjs:master May 5, 2018

ghost removed the in progress label May 5, 2018

PeterDaveHello added a commit that referenced this pull request May 5, 2018

Import snarkdown from npm, update "filename", cc #11830

849b98b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add snarkdown w/ npm auto-update via single package.json #11830

Add snarkdown w/ npm auto-update via single package.json #11830

pyvkd commented Sep 13, 2017 •

edited

Loading

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

PeterBot left a comment

sufuf3 left a comment •

edited by extend1994

Loading

sufuf3 Sep 14, 2017

sufuf3 Sep 14, 2017

sufuf3 commented Sep 14, 2017 •

edited

Loading

PeterDaveHello commented Sep 15, 2017

sufuf3 commented Sep 15, 2017

pyvkd commented Sep 15, 2017

PeterDaveHello commented Sep 15, 2017

PeterBot left a comment

PeterDaveHello commented Sep 16, 2017

PeterBot left a comment

PeterDaveHello commented Sep 17, 2017

PeterBot left a comment

sufuf3 left a comment

sufuf3 commented Sep 21, 2017

PeterBot left a comment

extend1994 left a comment

PeterDaveHello left a comment

PeterBot commented Apr 19, 2018

sufuf3 commented Apr 23, 2018

PeterDaveHello left a comment •

edited

Loading

PeterBot left a comment

PeterDaveHello commented May 5, 2018

Add snarkdown w/ npm auto-update via single package.json #11830

Add snarkdown w/ npm auto-update via single package.json #11830

Conversation

pyvkd commented Sep 13, 2017 • edited Loading

Profile of the lib

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment • edited by extend1994 Loading

Choose a reason for hiding this comment

sufuf3 Sep 14, 2017

Choose a reason for hiding this comment

sufuf3 Sep 14, 2017

Choose a reason for hiding this comment

sufuf3 commented Sep 14, 2017 • edited Loading

PeterDaveHello commented Sep 15, 2017

sufuf3 commented Sep 15, 2017

pyvkd commented Sep 15, 2017

PeterDaveHello commented Sep 15, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Sep 16, 2017

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Sep 17, 2017

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

sufuf3 commented Sep 21, 2017

PeterBot left a comment

Choose a reason for hiding this comment

extend1994 left a comment

Choose a reason for hiding this comment

PeterDaveHello left a comment

Choose a reason for hiding this comment

PeterBot commented Apr 19, 2018

sufuf3 commented Apr 23, 2018

PeterDaveHello left a comment • edited Loading

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented May 5, 2018

pyvkd commented Sep 13, 2017 •

edited

Loading

sufuf3 left a comment •

edited by extend1994

Loading

sufuf3 commented Sep 14, 2017 •

edited

Loading

PeterDaveHello left a comment •

edited

Loading