-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add smooth-scrollbar v6.0.4 with npm autoupdate config #7964
Conversation
024d0f4
to
ea36cad
Compare
@x09326 The latest version updated to v6.0.1. Please help me review it. Thank you. |
{ | ||
"basePath": "dist", | ||
"files": [ | ||
"**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the origin file (src/smooth_scrollbar.js).
@PeterDaveHello we need that right?
Do we need to ask the author to modify the name of minified files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...actually I'm thinking that if it's necessary to publish an unminified version of compiled source. Since the project is written in es6 and pre-compiled with babel, it would be hard to debug without souce maps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idiotWu so what about just host the dist folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterDaveHello that would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ea36cad
to
9eb358c
Compare
@x09326 The latest version is v6.0.4. Please help me review again, thank you. |
@PeterDaveHello |
PR for #7823
@x09326 Please help me review this pull request, thank you.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist
close #7823, cc @idiotWu