Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smooth-scrollbar v6.0.4 with npm autoupdate config #7964

Merged
merged 1 commit into from
May 22, 2016

Conversation

pvnr0082t
Copy link
Contributor

@pvnr0082t pvnr0082t commented May 18, 2016

PR for #7823
@x09326 Please help me review this pull request, thank you.

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

close #7823, cc @idiotWu

@pvnr0082t pvnr0082t changed the title add smooth-scrollbar v5.6.5 with npm autoupdate config add smooth-scrollbar v6.0.1 with npm autoupdate config May 18, 2016
@pvnr0082t
Copy link
Contributor Author

@x09326 The latest version updated to v6.0.1. Please help me review it. Thank you.

{
"basePath": "dist",
"files": [
"**/*"
Copy link
Contributor

@x09326 x09326 May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the origin file (src/smooth_scrollbar.js).

@PeterDaveHello we need that right?
Do we need to ask the author to modify the name of minified files?

Copy link

@idiotWu idiotWu May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...actually I'm thinking that if it's necessary to publish an unminified version of compiled source. Since the project is written in es6 and pre-compiled with babel, it would be hard to debug without souce maps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idiotWu so what about just host the dist folder?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterDaveHello that would be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idiotWu thanks!
@x09326 so we just leave it alone.

@pvnr0082t
Copy link
Contributor Author

@x09326 The latest version is v6.0.4. Please help me review again, thank you.

@pvnr0082t pvnr0082t changed the title add smooth-scrollbar v6.0.1 with npm autoupdate config add smooth-scrollbar v6.0.4 with npm autoupdate config May 21, 2016
@x09326
Copy link
Contributor

x09326 commented May 22, 2016

@PeterDaveHello
I think this PR is okay, please help me review it, thanks.

@PeterDaveHello PeterDaveHello merged commit 29bf1e8 into cdnjs:master May 22, 2016
@pvnr0082t pvnr0082t deleted the smooth-scrollbar branch July 18, 2016 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add smooth-scrollbar
4 participants