add jQuery-flexImages@1.0.4 w/ git auto-update #8573

x09326 · 2016-07-21T06:24:20Z

PR for #8533
@pvnr0082t please help me review it, thanks.
Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required):https://github.com/Pixabay/jQuery-flexImages
Official website (optional, not the repository):
NPM package url (optional):
GitHub / Bitbucket popularity (required):
- Count of stars:122
- Count of watchers:8
- Count of forks:34
NPM download stats (optional):
- Downloads in the last day:
- Downloads in the last week:
- Downloads in the last month:

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

close #8533, cc @SimonSteinberger

pvnr0082t · 2016-07-21T07:52:19Z

ajax/libs/jQuery-flexImages/package.json

+      "url": "https://pixabay.com/users/Simon/",
+      "email": "simon@pixabay.com"
+    }
+  ],


@x09326 We can just use an object and remove array.

pvnr0082t · 2016-07-21T07:56:59Z

@PeterDaveHello The latest version we can get from https://goodies.pixabay.com/jquery/flex-images/demo.html is v1.0.4 but the latest version on GitHub is v1.0.1. Is it better to add v1.0.4?

x09326 · 2016-07-21T07:59:46Z

I think they forget to update the latest version.
I will confirm that with them.

PeterDaveHello · 2016-08-22T15:38:05Z

@x09326 can you manually add the tagged versions and v1.0.4 first? Thanks.

x09326 · 2016-09-21T05:45:49Z

@pvnr0082t
I have added the tagged versions.
Please help me review it, thanks.

pvnr0082t · 2016-09-21T05:56:12Z

@x09326 I think https://goodies.pixabay.com/jquery/flex-images/demo.html can be homepage.

pvnr0082t · 2016-09-21T05:59:01Z

The latest minify tool will not minify jquery.flex-images.css in v1.0.4 because there are only 3 lines. I think you can remove jquery.flex-images.min.css and jquery.flex-images.min.css.map

x09326 · 2016-09-21T06:12:12Z

@pvnr0082t
done!

pvnr0082t · 2016-09-21T07:03:41Z

@x09326 Please also mention related issue in second commit. Thanks.

x09326 · 2016-09-21T07:24:36Z

@pvnr0082t
I haved modified the commit message.
Please help me review it, thanks.

pvnr0082t · 2016-09-21T08:35:22Z

multi-commit PR need multi reviewer.

pvnr0082t · 2016-09-21T08:35:57Z

LGTM

kennynaoh · 2016-09-22T04:04:01Z

@PeterDaveHello
Should we also need to add old versions in this case?
Thanks!

PeterDaveHello · 2016-09-22T07:44:07Z

@kennynaoh your question is not clear at all, I have no idea what the situation you are talking about, would you please give some details?

@x09326 I found that the version v1.0.2/1.0.3 are mentioned in the readme but not tagged, would you please trace its commit log and manually add them? Thanks.

kennynaoh · 2016-09-22T08:14:23Z

@PeterDaveHello
Because it has git tag in v1.0.0 and v1.0.1, I think it can be automatically added.
That's what I mean.
But there has old version v1.0.2 and v1.0.3 without tag you mentioned, it should be added manually now.
Thanks!

PeterDaveHello · 2016-09-22T08:15:05Z

@kennynaoh Yes, only manually add v1.0.0/1.0.1 here makes no sense.

kennynaoh · 2016-09-22T08:47:11Z

OK

@SimonSteinberger

close cdnjs#8533, cc @SimonSteinberger

Manually add the other versions from git repo because git auto-update can't get some versions, cc cdnjs#8533

x09326 · 2016-09-23T06:29:14Z

@kennynaoh @pvnr0082t
I have added 1.0.2 and 1.0.3 by tracing commit log.
Please help me review it, thanks.

kennynaoh · 2016-09-23T07:14:43Z

LGTM

pvnr0082t · 2016-09-23T07:37:46Z

@PeterDaveHello The files added by tracing commit log should be the last change? I mean, for example, Pixabay/jQuery-flexImages@eb83790 and Pixabay/jQuery-flexImages@7757cd2 are different, but it seems like @x09326 add the latter(older) one.

PeterDaveHello · 2016-09-23T07:38:29Z

@pvnr0082t Nope, shuold be the first change tagged that version, thanks.

pvnr0082t · 2016-09-23T07:51:03Z

LGTM ping @PeterDaveHello

x09326 assigned pvnr0082t Jul 21, 2016

PeterDaveHello added the in progress label Jul 21, 2016

pvnr0082t reviewed Jul 21, 2016
View reviewed changes

pvnr0082t assigned x09326 and unassigned pvnr0082t Jul 21, 2016

x09326 mentioned this pull request Jul 21, 2016

About the version tag Pixabay/jQuery-flexImages#21

Open

x09326 force-pushed the jQuery-flexImages branch from 428b827 to de1d044 Compare July 21, 2016 08:13

x09326 force-pushed the jQuery-flexImages branch from de1d044 to 972905c Compare September 21, 2016 05:45

x09326 assigned pvnr0082t and unassigned x09326 Sep 21, 2016

pvnr0082t assigned x09326 and unassigned pvnr0082t Sep 21, 2016

x09326 force-pushed the jQuery-flexImages branch from 972905c to 7466ee9 Compare September 21, 2016 06:10

x09326 assigned pvnr0082t and unassigned x09326 Sep 21, 2016

pvnr0082t assigned x09326 and unassigned pvnr0082t Sep 21, 2016

x09326 force-pushed the jQuery-flexImages branch from 7466ee9 to e13319b Compare September 21, 2016 07:24

x09326 assigned pvnr0082t and unassigned x09326 Sep 21, 2016

pvnr0082t assigned kennynaoh and unassigned pvnr0082t Sep 21, 2016

PeterDaveHello assigned Piicksarn Sep 21, 2016

PeterDaveHello assigned x09326 Sep 22, 2016

x09326 added 2 commits September 23, 2016 14:22

add jQuery-flexImages@1.0.4 w/ git auto-update

abac24b

close cdnjs#8533, cc @SimonSteinberger

Add other versions of jQuery-flexImages

3456bc6

Manually add the other versions from git repo because git auto-update can't get some versions, cc cdnjs#8533

x09326 force-pushed the jQuery-flexImages branch from e13319b to 3456bc6 Compare September 23, 2016 06:25

x09326 assigned pvnr0082t and unassigned x09326 Sep 23, 2016

pvnr0082t assigned PeterDaveHello Sep 23, 2016

PeterDaveHello merged commit 093b15f into cdnjs:master Sep 23, 2016

PeterDaveHello removed the in progress label Sep 23, 2016

x09326 deleted the jQuery-flexImages branch October 12, 2016 11:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add jQuery-flexImages@1.0.4 w/ git auto-update #8573

add jQuery-flexImages@1.0.4 w/ git auto-update #8573

x09326 commented Jul 21, 2016

pvnr0082t Jul 21, 2016

pvnr0082t commented Jul 21, 2016

x09326 commented Jul 21, 2016

PeterDaveHello commented Aug 22, 2016

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016 •

edited

Loading

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016 •

edited

Loading

pvnr0082t commented Sep 21, 2016

kennynaoh commented Sep 22, 2016

PeterDaveHello commented Sep 22, 2016

kennynaoh commented Sep 22, 2016

PeterDaveHello commented Sep 22, 2016

kennynaoh commented Sep 22, 2016

x09326 commented Sep 23, 2016

kennynaoh commented Sep 23, 2016

pvnr0082t commented Sep 23, 2016

PeterDaveHello commented Sep 23, 2016

pvnr0082t commented Sep 23, 2016 •

edited

Loading

add jQuery-flexImages@1.0.4 w/ git auto-update #8573

add jQuery-flexImages@1.0.4 w/ git auto-update #8573

Conversation

x09326 commented Jul 21, 2016

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

pvnr0082t Jul 21, 2016

Choose a reason for hiding this comment

pvnr0082t commented Jul 21, 2016

x09326 commented Jul 21, 2016

PeterDaveHello commented Aug 22, 2016

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016 • edited Loading

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016

x09326 commented Sep 21, 2016

pvnr0082t commented Sep 21, 2016 • edited Loading

pvnr0082t commented Sep 21, 2016

kennynaoh commented Sep 22, 2016

PeterDaveHello commented Sep 22, 2016

kennynaoh commented Sep 22, 2016

PeterDaveHello commented Sep 22, 2016

kennynaoh commented Sep 22, 2016

x09326 commented Sep 23, 2016

kennynaoh commented Sep 23, 2016

pvnr0082t commented Sep 23, 2016

PeterDaveHello commented Sep 23, 2016

pvnr0082t commented Sep 23, 2016 • edited Loading

pvnr0082t commented Sep 21, 2016 •

edited

Loading

pvnr0082t commented Sep 21, 2016 •

edited

Loading

pvnr0082t commented Sep 23, 2016 •

edited

Loading