This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
[Website] Implement breadcrumb on all pages following Schema spec #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
changed the title
MattIPv4
changed the title
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
2 times, most recently
from
4aa340b
to
6c6b7d8
Compare
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
from
6c6b7d8
to
33a1699
Compare
|
Conflicts resolved, rebased against latest master. |
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
from
33a1699
to
ac88479
Compare
MattIPv4
commented
Sep 8, 2019
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
2 times, most recently
from
97fec0b
to
28a960a
Compare
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
from
69ff65f
to
f04c215
Compare
robocdnjs
force-pushed
the
master
branch
3 times, most recently
from
7978f9c
to
7ccebf4
Compare
MattIPv4
force-pushed
the
MattIPv4-breadcrumbs
branch
from
f04c215
to
e71d004
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143 by implementing breadcrumbs on all public pages, following the Schema spec for breadcrumb element structure and attributes.
Closes #178 which implements breadcrumbs but does not fully follow the spec.