Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surreal w/ git auto-update #1830

Merged
merged 6 commits into from
Aug 11, 2024
Merged

Add surreal w/ git auto-update #1830

merged 6 commits into from
Aug 11, 2024

Conversation

jph00
Copy link
Contributor

@jph00 jph00 commented Jun 26, 2024

Adding Surreal.js library to cdnjs.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error indicates, to pull from a GitHub repository, there needs to be tags for each version that we should pull into cdnjs.

@jph00
Copy link
Contributor Author

jph00 commented Jul 17, 2024

Thanks @MattIPv4 -- sorry about that. Should be fixed now.

@jph00 jph00 requested a review from MattIPv4 July 24, 2024 02:56
packages/s/surreal.json Show resolved Hide resolved
@jph00
Copy link
Contributor Author

jph00 commented Aug 4, 2024

I've checked with @gnat, and he feels that the approach of pulling from my fork is preferred. He does not want to tag releases in the main project, in order to avoid implicitly encouraging the use of build machinery.

@jph00 jph00 requested a review from MattIPv4 August 4, 2024 23:02
@MattIPv4
Copy link
Member

Given the context in #1831 (comment), I'm happy to let this through with the different source.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4 MattIPv4 merged commit 4baf4b9 into cdnjs:master Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants