-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surreal w/ git auto-update #1830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the CI error indicates, to pull from a GitHub repository, there needs to be tags for each version that we should pull into cdnjs.
Thanks @MattIPv4 -- sorry about that. Should be fixed now. |
I've checked with @gnat, and he feels that the approach of pulling from my fork is preferred. He does not want to tag releases in the main project, in order to avoid implicitly encouraging the use of build machinery. |
Given the context in #1831 (comment), I'm happy to let this through with the different source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding Surreal.js library to cdnjs.